Re: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet handling helpers

Etienne CARRIERE
2024-07-23T13:41:41Z

Hi,

On Thursday, July 11, 2024, Peng Fan wrote:
> > Subject: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet
> > handling helpers
> >
> > Introduce a pair of structures initialized to contain all the existing
> > packet handling helpers, both for transports based on shared memory
> > and messages.
> >
> > No functional change.
> >
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > ---
> > v1 --> v2
> > - fixed commit message
> > ---
> ......
>
> > d33a704e5814..f4ba38afe0bb 100644
> > --- a/drivers/firmware/arm_scmi/msg.c
> > +++ b/drivers/firmware/arm_scmi/msg.c
> > @@ -4,8 +4,8 @@
> >   *
> >   * Derived from shm.c.
> >   *
> > - * Copyright (C) 2019-2021 ARM Ltd.
> > - * Copyright (C) 2020-2021 OpenSynergy GmbH
> > + * Copyright (C) 2019-2024 ARM Ltd.
> > + * Copyright (C) 2020-2024 OpenSynergy GmbH
>
> Nitpick: OpenSynergy year should be kept unchanged?

I agree. Copyright dates on original non-Arm contributors should
not be changed, here and in patch 5/8, 6/8 and 7/8.

>
> Otherwise looks good:
> Reviewed-by: Peng Fan <peng.fan@nxp.com>