From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wolfram Sang <wsa@kernel.org>, Jean Delvare <khali@linux-fr.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] i2c: smbus: Handle stuck alerts
Date: Mon, 29 Jul 2024 10:04:35 +0200 [thread overview]
Message-ID: <ZqdNE2nFEmRU2y-l@shikoro> (raw)
In-Reply-To: <f5886c83-27c2-475d-b75a-4ad107d039ed@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
> > I think this can only work if we require .alert-handlers to start with a
> > sanity check to make sure their device really raised an interrupt
> > condition. And then return either -EBUSY or 0, similar to IRQ_HANDLED or
> > IRQ_NONE. Or?
>
> I think so, but I am not sure if it is worth the effort. It would require
> changing the API, and each driver supporting alert callbacks would have
> to implement code to detect if it actually got an interrupt.
The more I think about it, the more I like this proposal. I mean, irq
subsystem has IRQ_NONE also for a reason. And we do not have that many
alert handlers to convert. They could all return EBUSY by default
because that is what they currently behave like anyhow. That being said,
it will not be a top priority on my list.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-07-29 8:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 17:28 [PATCH 0/2] i2c: smbus: Handle stuck alerts Guenter Roeck
2022-01-10 17:28 ` [PATCH 1/2] i2c: smbus: Improve handling of " Guenter Roeck
2024-07-28 20:01 ` Wolfram Sang
2024-07-29 7:49 ` Wolfram Sang
2022-01-10 17:28 ` [PATCH 2/2] i2c: smbus: Send alert notifications to all devices if source not found Guenter Roeck
2024-07-28 20:04 ` Wolfram Sang
2024-07-29 0:31 ` Guenter Roeck
2024-07-29 7:57 ` Wolfram Sang
2024-07-29 14:23 ` Guenter Roeck
2024-07-29 18:36 ` Wolfram Sang
2024-07-29 18:44 ` Guenter Roeck
2024-07-29 20:52 ` Wolfram Sang
2024-07-29 21:39 ` Guenter Roeck
2024-06-12 17:49 ` [PATCH 0/2] i2c: smbus: Handle stuck alerts Guenter Roeck
2024-06-12 20:21 ` Wolfram Sang
2024-06-12 20:29 ` Guenter Roeck
2024-07-28 19:59 ` Wolfram Sang
2024-07-29 0:31 ` Guenter Roeck
2024-07-29 8:04 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqdNE2nFEmRU2y-l@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox