From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wolfram Sang <wsa@kernel.org>, Jean Delvare <khali@linux-fr.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: smbus: Send alert notifications to all devices if source not found
Date: Mon, 29 Jul 2024 22:52:09 +0200 [thread overview]
Message-ID: <ZqgA-Qo8bccaouUr@shikoro> (raw)
In-Reply-To: <c58ca576-2763-4f73-bc0e-c33677c5228b@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
> > The code I am suggesting is bascially yours without the retries
> > variable:
> >
> > status = device_for_each_child(&ara->adapter->dev, &data,
> > smbus_do_alert);
> > if (data.addr == prev_addr && status != -EBUSY) {
> > device_for_each_child(&ara->adapter->dev, &data,
> > smbus_do_alert_force);
> > break;
> > }
> > prev_addr = data.addr;
> >
> > Makes sense or am I missing something?
> >
>
> Yes, that should work and is indeed simpler. You are correct, the
> additional loop should not be necessary since smbus_do_alert_force()
> should already call all connected drivers and hopefully clear
> the alert condition on those.
Great that we are aligned now! Do you have time to rework and test the
patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-07-29 20:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 17:28 [PATCH 0/2] i2c: smbus: Handle stuck alerts Guenter Roeck
2022-01-10 17:28 ` [PATCH 1/2] i2c: smbus: Improve handling of " Guenter Roeck
2024-07-28 20:01 ` Wolfram Sang
2024-07-29 7:49 ` Wolfram Sang
2022-01-10 17:28 ` [PATCH 2/2] i2c: smbus: Send alert notifications to all devices if source not found Guenter Roeck
2024-07-28 20:04 ` Wolfram Sang
2024-07-29 0:31 ` Guenter Roeck
2024-07-29 7:57 ` Wolfram Sang
2024-07-29 14:23 ` Guenter Roeck
2024-07-29 18:36 ` Wolfram Sang
2024-07-29 18:44 ` Guenter Roeck
2024-07-29 20:52 ` Wolfram Sang [this message]
2024-07-29 21:39 ` Guenter Roeck
2024-06-12 17:49 ` [PATCH 0/2] i2c: smbus: Handle stuck alerts Guenter Roeck
2024-06-12 20:21 ` Wolfram Sang
2024-06-12 20:29 ` Guenter Roeck
2024-07-28 19:59 ` Wolfram Sang
2024-07-29 0:31 ` Guenter Roeck
2024-07-29 8:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqgA-Qo8bccaouUr@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox