Re: [PATCH v2 0/5] uprobes: misc cleanups/simplifications

Jiri Olsa
2024-07-30T07:42:26Z

On Mon, Jul 29, 2024 at 03:44:44PM +0200, Oleg Nesterov wrote:
> Peter, I don't think these changes can really complicate your ongoing work.
> But again, if you are going to send the next version "soon" I can rebase
> these cleanups on top of it.
>
> Andrii, I dared to preserve your acks, all the changes are simple.
>
> Changes since v1:
>
> - update the comment in register_for_each_vma()
> - remove the now unused "struct path *" arg from bpf_uprobe_unregister()
> - forward-declare struct uprobe in include/linux/uprobes.h
> - kernel-doc fixes/updates
> - fix use-after free in uprobe_unregister(). See "TODO:" in 5/5.

lgtm

Reviewed-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

>
> Oleg.
> ---
>
> include/linux/uprobes.h | 22 +++++------
> kernel/events/uprobes.c | 96 +++++++++++++++++----------------------------
> kernel/trace/bpf_trace.c | 25 ++++++------
> kernel/trace/trace_uprobe.c | 31 ++++++---------
> 4 files changed, 69 insertions(+), 105 deletions(-)
>