From: Sean Christopherson <seanjc@google.com>
To: Kai Huang <kai.huang@intel.com>
Cc: "bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"wangyuli@uniontech.com" <wangyuli@uniontech.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"xiangzelong@uniontech.com" <xiangzelong@uniontech.com>,
"baimingcong@uniontech.com" <baimingcong@uniontech.com>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"guanwentao@uniontech.com" <guanwentao@uniontech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"haitao.huang@linux.intel.com" <haitao.huang@linux.intel.com>,
"wubo@uniontech.com" <wubo@uniontech.com>
Subject: Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX
Date: Tue, 30 Jul 2024 10:56:25 -0700 [thread overview]
Message-ID: <ZqkpSX8xfbny7L0e@google.com> (raw)
In-Reply-To: <a56bc12f6c60107c935db31d7330d28980ac4d5a.camel@intel.com>
On Tue, Jul 30, 2024, Kai Huang wrote:
> On Tue, 2024-07-30 at 10:49 +0800, WangYuli wrote:
> > When SGX is not supported by the BIOS, we still output the error
> > 'SGX disabled by BIOS', which can be confusing since there might not be
> > an SGX-related option in the BIOS settings.
>
> +linux-sgx list, Jarkko, Haitao.
>
> This message is only printed when SGX is reported in CPUID but is not
> enabled in the FEAT_CTL MSR. I can only recall this can happen when the
> BIOS actually provides an option for the user to turn on/off SGX, in
> which case the current message is correct.
FWIW, this could easily happen with a virtual machine, e.g. running an old QEMU
with `-cpu host`.
next prev parent reply other threads:[~2024-07-30 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 2:49 [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX WangYuli
2024-07-30 11:57 ` Huang, Kai
2024-07-30 17:56 ` Sean Christopherson [this message]
2024-07-30 22:48 ` Huang, Kai
2024-07-31 3:58 ` WangYuli
2024-07-31 3:22 ` WangYuli
2024-07-31 12:20 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqkpSX8xfbny7L0e@google.com \
--to=seanjc@google.com \
--cc=baimingcong@uniontech.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=guanwentao@uniontech.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wangyuli@uniontech.com \
--cc=wubo@uniontech.com \
--cc=x86@kernel.org \
--cc=xiangzelong@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox