From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9365B1662F4 for ; Tue, 30 Jul 2024 20:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722371093; cv=none; b=AiXzM1xsO8igZ+HrXQXL8SRUu8LPLXdZxkf4oVMGbQUthNuBQ34LGj+UGUzFnlRLcoom2lhqeDGoiiGey5D1w2b9WBXeGIYjDp6HmC/UgIUvAZCfB2YJwVk7adwzEOywxDP+NSl9NY7NcAcVt7RFeweGrXMli9MUIkSqlBLhBP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722371093; c=relaxed/simple; bh=z7GWh0jTkNCHG+CucoLOogt/YnUgFnvIKYAlKOoO2gU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=QAmItpFqSDyG/HONj/H8EyiGqRjdRpNaVAahFSxrc9g9pNHDkvhCqkH5mF6tMO8+5G/K064Cu3z4fIqgysa7bHX15n27VbtxDc8oX8BE3D0WpEnjV4h8b6VAs/PNghV2w8KHrdzn796ZDel4q1ZBGrSI7KI7zL80DO57fv2bhWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bnaI6vaV; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bnaI6vaV" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-79d95667cfaso5113582a12.2 for ; Tue, 30 Jul 2024 13:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722371091; x=1722975891; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7S3Oli6i7JzEF8SVo1JkM4Mpho9qGmQAiVdyShh3yxA=; b=bnaI6vaVgoSQZhI6xSFDA63Do2WIrkqSxndzYqvDzbgdl+TkkT8f9pJvRmtAvnw26W N71VnDK+GsvbYGczFfcmHxd0C+8Zz35zgzsZ68JwwI9TgtGntMIviQu6EjOu0b/ZnpLk HCYjLaIqj+VQYaXE7cBUnnWMtHmW+QpEKBLb1C3Yn9YrpVpu/jQgQHW5l9sAnXFHx1uv VB90IK+MPKg4sFzUrpbcyMHjb8m3EWymcSM3RvjThzHvjrNVIID8mCmLyEuAbUNQLDQN qG/f/8I1fQ1diVOEl/smNtwBIl1eOCS+6uX0C9cIHRWqK2tVHWfufyRTzFSkm3i6Dvt6 Cb+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722371091; x=1722975891; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7S3Oli6i7JzEF8SVo1JkM4Mpho9qGmQAiVdyShh3yxA=; b=BIhEc6CAv/HkeO1lRp1dFGDn+oirt8jNAN5M3q5b8iVs7IN7Nz3AcXVmojbzk/LNXG AAbS2qkFwqPvt+xlhIsFZldR04RzRtqAu+qkbBxgIwwnd6fhRpKong8OF2rXm+igmY80 THAN+j2fiRXIBVQaviQtkoPFmBMhYfJm8mOTxgjCpgKt85RfhOOjRkxZY181xWrc6JPo KanY0SDMsPUBHVi02vQsEAok33t250W1ZiykqCxrz9QmL9H8SnEnhNjbjBLI2TVLxRtd A6EeLhmdCRFXQuBGD1gakVZG1KSDK0uQKXS/yKtOSCuCoRw3JMSF1nWrSZmrXecJMcs5 1ArA== X-Forwarded-Encrypted: i=1; AJvYcCW33r5G0mpPpl+jv9u5XprCv+H9YneRTj/K6LSkFF1MOj6ntoFZ5jnGnKDil/MXpv3ftW7KGWDCCu/z4czjbbkaobGYgdLBtPrR4idv X-Gm-Message-State: AOJu0Yw3Gg4KY89UkRM9LNSn8Zn237kgYwDQyGXpYMkIkYIS9IvNz2q+ qac8NDQRKQqE7pH5DRELKJxZz7xhYMWhwikTX4V+bSuLzVOCmcZzQ+UO+OXLi9v77xZ87O1k09U cYg== X-Google-Smtp-Source: AGHT+IEPiHXtS314tlrQIAMbYrZnHsRms7BHYsbMaTjPiFclwHDMK7MPl03jGaRyUaHpVI56coh4fZoFV/g= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:6803:b0:2c9:7d81:fb1f with SMTP id 98e67ed59e1d1-2cf7e97a4d1mr361358a91.6.1722371090986; Tue, 30 Jul 2024 13:24:50 -0700 (PDT) Date: Tue, 30 Jul 2024 13:24:49 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240730174751.15824-1-john.allen@amd.com> Message-ID: Subject: Re: [PATCH] KVM: x86: Advertise SUCCOR and OVERFLOW_RECOV cpuid bits From: Sean Christopherson To: John Allen Cc: pbonzini@redhat.com, kvm@vger.kernel.org, thomas.lendacky@amd.com, bp@alien8.de, mlevitsk@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org, yazen.ghannam@amd.com Content-Type: text/plain; charset="us-ascii" On Tue, Jul 30, 2024, John Allen wrote: > On Tue, Jul 30, 2024 at 11:00:57AM -0700, Sean Christopherson wrote: > > On Tue, Jul 30, 2024, John Allen wrote: > > > Handling deferred, uncorrected MCEs on AMD guests is now possible with > > > additional support in qemu. Ensure that the SUCCOR and OVERFLOW_RECOV > > > bits are advertised to the guest in KVM. > > > > > > Suggested-by: Paolo Bonzini > > > Signed-off-by: John Allen > > > --- > > > arch/x86/kvm/cpuid.c | 2 +- > > > arch/x86/kvm/svm/svm.c | 7 +++++++ > > > 2 files changed, 8 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > > > index 2617be544480..4745098416c3 100644 > > > --- a/arch/x86/kvm/cpuid.c > > > +++ b/arch/x86/kvm/cpuid.c > > > @@ -1241,7 +1241,7 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function) > > > > > > /* mask against host */ > > > entry->edx &= boot_cpu_data.x86_power; > > > - entry->eax = entry->ebx = entry->ecx = 0; > > > + entry->eax = entry->ecx = 0; > > > > Needs an override to prevent reporting all of EBX to userspace. > > > > cpuid_entry_override(entry, CPUID_8000_0007_EBX); > > Right, I see what you mean. We just want to expose these specific bits > and not all of EBX. I think with the patch as it is along with the > change you suggest below, this should resolve this as the above case > already has the cpuid_entry_override just above where it cuts off. Heh, nope, it doesn't. The existing override is for EDX, this needs one for EBX.