Re: [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging

Jakub Kicinski
2024-07-30T14:48:28Z

On Tue, 30 Jul 2024 16:37:10 +0200 Paolo Abeni wrote:
> I think that better specifying the general guidance/expectation should
> be enough. What about extending the knob description with something alike:
> ---
> diff --git a/net/Kconfig.debug b/net/Kconfig.debug
> index 5e3fffe707dd..058cf031913b 100644
> --- a/net/Kconfig.debug
> +++ b/net/Kconfig.debug
> @@ -24,3 +24,5 @@ config DEBUG_NET
> help
> Enable extra sanity checks in networking.
> This is mostly used by fuzzers, but is safe to select.
> + This could introduce some very minimal overhead and
> + is not suggested for production systems.

I'd go with:

Enable extra sanity checks in networking.
- This is mostly used by fuzzers, but is safe to select.
+ This is mostly used by fuzzers, and may introduce some
+ minimal overhead, but is safe to select.

What's acceptable on prod systems really depends on the workload..