Re: [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging

Jakub Kicinski
2024-07-30T14:10:34Z

On Tue, 30 Jul 2024 13:15:57 +0200 Paolo Abeni wrote:
> > If thats the case why does it exist at all?

+1

> > I was under impression that entire reason for CONFIG_DEBUG_NET was
> > to enable more checks for fuzzers and the like, i.e. NOT for production
> > kernels.
>
> I feel like I already had this discussion and I forgot the outcome, if
> so I'm sorry. To me the "but is safe to select." part in the knob
> description means this could be enabled in production, and AFAICS the
> CONFIG_DEBUG_NET-enabled code so far respects that assumption.

I believe the previous discussion was page pool specific and there
wasn't as much of a conclusion as an acquiescence (read: we had more
important things on our minds than that argument ;)).

Should we set a bar for how much perf impact is okay?

FTR I suspect there will be no measurable perf impact here.