Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc`

Miguel Ojeda
2024-08-14T15:03:35Z

On Wed, Aug 14, 2024 at 4:00 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> If we keep them, we'd consequently also need to add them for vrealloc() and
> kvrealloc(). But again, they don't do anything for us, and hence are more
> misleading than helpful IMO.

In general, they could do something (e.g. `noreturn`), perhaps in the future.

Apart from being potentially misleading, do we gain something by
removing them? I guess simplicity in the file, but it is also simpler
to keep them aligned to the C side (which I guess is Alice's point),
and avoids having to keep track of what could have a present or future
impact in `bindgen`.

Cheers,
Miguel