From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C8615E88; Thu, 15 Aug 2024 15:45:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723736759; cv=none; b=GItVBVpzMx3rHv1FnAvWnCh+/TxT3jz9CGD6MXat/QWV+l7h4hoehv/LzXkm2de6j/lJ4YkWyZeK4SgFvSAOq8/mEHyUaM3RlMREcMGbIVFzjB1LsA8HXExVkqbbLc5KdfCxiM3ypYOXdcg5zPSYbkVp9MB3+2WPhPciNy86ukg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723736759; c=relaxed/simple; bh=Xp9jlxYgDXqltUmPuPufUyP7g6Q5pctnBv2GovQ16XE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F94WwCcjQ4jvHVpjl6xtUmxfJSs+4zimiKwcMFj4HKzLf+4rqSTFjHf6qhBkRgNSZon3b0JevYQidWDAN9IVBeCc8fDcFDcf2/6ANNve0WBaTelhEs71bjGWODBt7qTp57CtGv3iOjmM4nBGFIi7Ehm3AJHLQTa3K3vn8vweuNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74432C4AF09; Thu, 15 Aug 2024 15:45:53 +0000 (UTC) Date: Thu, 15 Aug 2024 16:45:51 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v10 03/40] mman: Add map_shadow_stack() flags Message-ID: References: <20240801-arm64-gcs-v10-0-699e2bd2190b@kernel.org> <20240801-arm64-gcs-v10-3-699e2bd2190b@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801-arm64-gcs-v10-3-699e2bd2190b@kernel.org> On Thu, Aug 01, 2024 at 01:06:30PM +0100, Mark Brown wrote: > In preparation for adding arm64 GCS support make the map_shadow_stack() > SHADOW_STACK_SET_TOKEN flag generic and add _SET_MARKER. The existing > flag indicats that a token usable for stack switch should be added to Nit: indicates > diff --git a/include/uapi/asm-generic/mman.h b/include/uapi/asm-generic/mman.h > index 57e8195d0b53..d6a282687af5 100644 > --- a/include/uapi/asm-generic/mman.h > +++ b/include/uapi/asm-generic/mman.h > @@ -19,4 +19,8 @@ > #define MCL_FUTURE 2 /* lock all future mappings */ > #define MCL_ONFAULT 4 /* lock all pages that are faulted in */ > > +#define SHADOW_STACK_SET_TOKEN (1ULL << 0) /* Set up a restore token in the shadow stack */ > +#define SHADOW_STACK_SET_MARKER (1ULL << 1) /* Set up a top of stack merker in the shadow stack */ s/merker/marker/ Otherwise: Reviewed-by: Catalin Marinas