From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Brian Norris <briannorris@chromium.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] tools build: Provide consistent build options for fixdep
Date: Thu, 15 Aug 2024 18:07:58 -0300 [thread overview]
Message-ID: <Zr5uLlWGUEMYaroE@x1> (raw)
In-Reply-To: <88a67613-9597-4770-b777-51975e163513@leemhuis.info>
On Thu, Aug 15, 2024 at 09:03:58AM +0200, Thorsten Leemhuis wrote:
> On 14.08.24 19:53, Alexander Gordeev wrote:
> > On Wed, Aug 14, 2024 at 10:35:00AM -0700, Brian Norris wrote:
> >
> >> FWIW, I already fielded some reports about this, and proposed a very
> >> similar (but not identical) fix:
> >>
> >> https://lore.kernel.org/lkml/20240814030436.2022155-1-briannorris@chromium.org/
> >>
> >> Frankly, I wasn't sure about HOSTxxFLAGS vs KBUILD_HOSTxxFLAGS -- and
> >> that's the difference between yours and mine. If yours works, that
> >> looks like the cleaner solution. So:
> >>
> >> Reviewed-by: Brian Norris <briannorris@chromium.org>
> >>
> >> Either way, it might be good to also include some of these tags if
> >> this is committed:
> >>
> >> Closes: https://lore.kernel.org/lkml/99ae0d34-ed76-4ca0-a9fd-c337da33c9f9@leemhuis.info/
> >> Fixes: ea974028a049 ("tools build: Avoid circular .fixdep-in.o.cmd issues")
> >
> > Ah, I missed the issue was reported already - I would include these tags otherwise.
> >
> > @Thorsten, would it be possible to test this fix?
>
> Yeah, np. This one works as well, so feel free to add:
>
> Tested-by: Thorsten Leemhuis <linux@leemhuis.info>
Thanks everybody, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2024-08-15 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:30 [PATCH] tools build: Provide consistent build options for fixdep Alexander Gordeev
2024-08-14 17:35 ` Brian Norris
2024-08-14 17:53 ` Alexander Gordeev
2024-08-15 7:03 ` Thorsten Leemhuis
2024-08-15 21:07 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr5uLlWGUEMYaroE@x1 \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=briannorris@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox