Re: [PATCH net-next v1 1/1] phy: dp83td510: Utilize ALCD for cable length measurement when link is active

[Oleksij Rempel <o.rempel@pengutronix.de>]

On Fri, Aug 16, 2024 at 03:10:35PM +0200, Andrew Lunn wrote:
> > The DP83TD510 PHY provides an alternative through ALCD (Active Link
> > Cable Diagnostics), which allows for cable length measurement without
> > disrupting an active link. Since a live link indicates no short or open
> > cable states, ALCD can be used effectively to gather cable length
> > information.
> 
> Is this specific to TI?

It seems to be, yes. I assume they are using echo cancellation values or
some thing like this.

> Did you compare ALCD to TDR length measurement? Are they about the
> same?

Default ALCD values are about 20meters off. Which seems to be ok for
1000meter cable. TI describes calibration procedure for ALCD to provide
better measurements, but so far it was good enough. The problem with
this calibration is: it seems to be different for different cables, so
it make no sense to integrate it in kernel.

> I'm just thinking about if we want to include an additional
> attribute in ethnl_cable_test_fault_length() to indicate how the
> measurement was performed.

Sounds good. In this case user space will be able to know how to correct
this values.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |