From: Matthew Wilcox <willy@infradead.org>
To: crwulff@gmail.com
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Paul Cercueil <paul@crapouillou.net>,
Christian Brauner <brauner@kernel.org>,
Eric Farman <farman@linux.ibm.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Dmitry Antipov <dmantipov@yandex.ru>,
Jeff Layton <jlayton@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
David Sands <david.sands@biamp.com>
Subject: Re: [PATCH v4] usb: gadget: f_fs: add capability for dfu run-time descriptor
Date: Mon, 5 Aug 2024 04:39:21 +0100 [thread overview]
Message-ID: <ZrBJaW_EwNf_T_WZ@casper.infradead.org> (raw)
In-Reply-To: <20240805000639.619232-2-crwulff@gmail.com>
On Sun, Aug 04, 2024 at 08:06:40PM -0400, crwulff@gmail.com wrote:
> diff --git a/include/uapi/linux/usb/ch9.h b/include/uapi/linux/usb/ch9.h
> index 44d73ba8788d..91f0f7e214a5 100644
> --- a/include/uapi/linux/usb/ch9.h
> +++ b/include/uapi/linux/usb/ch9.h
> @@ -254,6 +254,9 @@ struct usb_ctrlrequest {
> #define USB_DT_DEVICE_CAPABILITY 0x10
> #define USB_DT_WIRELESS_ENDPOINT_COMP 0x11
> #define USB_DT_WIRE_ADAPTER 0x21
> +/* From USB Device Firmware Upgrade Specification, Revision 1.1 */
> +#define USB_DT_DFU_FUNCTIONAL 0x21
This is the only place in the entire patch where you explain what "DFU"
means. Is this really such a well-known acronym that it doesn't need to
be in the documentation or the commit message?
next prev parent reply other threads:[~2024-08-05 3:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 0:06 [PATCH v4] usb: gadget: f_fs: add capability for dfu run-time descriptor crwulff
2024-08-05 3:39 ` Matthew Wilcox [this message]
2024-08-05 23:39 ` Chris Wulff
2024-08-05 7:01 ` Greg Kroah-Hartman
2024-08-06 0:21 ` Chris Wulff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrBJaW_EwNf_T_WZ@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=crwulff@gmail.com \
--cc=david.sands@biamp.com \
--cc=dmantipov@yandex.ru \
--cc=farman@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox