From: Sascha Hauer <s.hauer@pengutronix.de>
To: Kalle Valo <kvalo@kernel.org>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
David Lin <yu-hao.lin@nxp.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v3 1/3] wifi: mwifiex: simplify WPA flags setting
Date: Mon, 5 Aug 2024 09:36:56 +0200 [thread overview]
Message-ID: <ZrCBGA29KbqkTgJU@pengutronix.de> (raw)
In-Reply-To: <172276187336.2804131.2752806886332298409.kvalo@kernel.org>
On Sun, Aug 04, 2024 at 08:57:54AM +0000, Kalle Valo wrote:
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> > The WPA flags setting only depends on the wpa_versions bitfield and not
> > on the AKM suite, so move it out of the switch/case to simplify the code
> > a bit. Also set bss_config->protocol to zero explicitly. This is done
> > only to make the code clearer, bss_config has been zero alloced by the
> > caller, so should be zero already. No functional change intended.
> >
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > Acked-by: Brian Norris <briannorris@chromium.org>
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> There were conflicts on wireless-next, please rebase.
Thanks for noting. Just sent out a v4.
I realized the host-mlme patches are merged in wireless-next. I had them
in my tree anyway already, so the necessary changes looked all familiar.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-08-05 7:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 7:09 [PATCH v3 0/3] mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-23 7:09 ` [PATCH v3 1/3] wifi: mwifiex: simplify WPA flags setting Sascha Hauer
2024-08-04 8:57 ` Kalle Valo
2024-08-05 7:36 ` Sascha Hauer [this message]
2024-07-23 7:09 ` [PATCH v3 2/3] wifi: mwifiex: fix key_mgmt setting Sascha Hauer
2024-07-23 7:52 ` Francesco Dolcini
2024-07-23 17:10 ` Brian Norris
2024-07-23 7:09 ` [PATCH v3 3/3] wifi: mwifiex: add support for WPA-PSK-SHA256 Sascha Hauer
2024-07-23 17:10 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrCBGA29KbqkTgJU@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=briannorris@chromium.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox