Re: [PATCH v4 08/28] rust: types: implement `Unique`

Danilo Krummrich
2024-08-06T23:16:35Z

On Tue, Aug 06, 2024 at 07:28:45PM +0200, Miguel Ojeda wrote:
> On Tue, Aug 6, 2024 at 7:22 PM Benno Lossin <benno.lossin@proton.me> wrote:
> >
> > I think I already asked this, but the code until this point is copied
> > from the rust stdlib and nowhere cited, does that work with the
> > licensing?
>
> No, it doesn't. They should be put into its own file with the right
> license and a paragraph about it, e.g. the other `std_vendor.rs` files
> we have (if it is just about `Unique`, it could go in the existing one
> at the `kernel` level).

Thanks for catching this, I once thought about it and then forgot about it
entirely.

I didn't know about std_vendor.rs, that's pretty convenient. I will move it over
in case we don't drop `Unique` entirely.

>
> Cheers,
> Miguel
>