From: Breno Leitao <leitao@debian.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
kuba@kernel.org,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] docs: fault-injection: document cache-filter feature for failslab
Date: Thu, 8 Aug 2024 00:41:34 -0700 [thread overview]
Message-ID: <ZrR2rlVkLqp0GXgt@gmail.com> (raw)
In-Reply-To: <87plqkrwns.fsf@trenco.lwn.net>
On Wed, Aug 07, 2024 at 12:54:31PM -0600, Jonathan Corbet wrote:
> Breno Leitao <leitao@debian.org> writes:
>
> > The failslab fault injection mechanism has an undocumented capability
> > that provides significant utility in testing and debugging. This feature,
> > introduced in commit 4c13dd3b48fcb ("failslab: add ability to filter slab
> > caches"), allows for targeted error injection into specific slab caches.
> >
> > However, it was inadvertently left undocumented at the time of its
> > implementation.
> >
> > Add documentation for the cache-filter feature in the failslab mode
> > description. Also, providing a practical example demonstrating how to
> > use cache-filter to inject failures specifically when allocating socket
> > buffers (skbs).
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > .../fault-injection/fault-injection.rst | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
>
> I've applied this, thanks.
>
> It seems to me that the fault-injection docs should really move under
> dev-tools; does anybody object to that?
I don't object at all. This doc should be inside dev-tools.
Thanks Jonathan,
--breno
next prev parent reply other threads:[~2024-08-08 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 12:09 [PATCH] docs: fault-injection: document cache-filter feature for failslab Breno Leitao
2024-07-28 9:07 ` Akinobu Mita
2024-08-07 18:54 ` Jonathan Corbet
2024-08-08 7:41 ` Breno Leitao [this message]
2024-08-11 15:38 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrR2rlVkLqp0GXgt@gmail.com \
--to=leitao@debian.org \
--cc=akinobu.mita@gmail.com \
--cc=corbet@lwn.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox