Re: [PATCH] docs: fault-injection: document cache-filter feature for failslab

Breno Leitao
2024-08-08T07:41:38Z

On Wed, Aug 07, 2024 at 12:54:31PM -0600, Jonathan Corbet wrote:
> Breno Leitao <leitao@debian.org> writes:
>
> > The failslab fault injection mechanism has an undocumented capability
> > that provides significant utility in testing and debugging. This feature,
> > introduced in commit 4c13dd3b48fcb ("failslab: add ability to filter slab
> > caches"), allows for targeted error injection into specific slab caches.
> >
> > However, it was inadvertently left undocumented at the time of its
> > implementation.
> >
> > Add documentation for the cache-filter feature in the failslab mode
> > description. Also, providing a practical example demonstrating how to
> > use cache-filter to inject failures specifically when allocating socket
> > buffers (skbs).
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > .../fault-injection/fault-injection.rst | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
>
> I've applied this, thanks.
>
> It seems to me that the fault-injection docs should really move under
> dev-tools; does anybody object to that?

I don't object at all. This doc should be inside dev-tools.

Thanks Jonathan,
--breno