Re: [PATCH v3 05/11] i2c: riic: Add suspend/resume support

Wolfram Sang
2024-08-08T15:15:10Z

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

On Thu, Jul 11, 2024 at 02:52:01PM +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Add suspend/resume support for the RIIC driver. This is necessary for the
> Renesas RZ/G3S SoC which support suspend to deep sleep state where power
> to most of the SoC components is turned off. As a result the I2C controller
> needs to be reconfigured after suspend/resume. For this, the reset line
> was stored in the driver private data structure as well as i2c timings.
> The reset line and I2C timings are necessary to re-initialize the
> controller after resume.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

? Doesn't apply on top of the previous patches for me?

> +static int riic_i2c_resume(struct device *dev)
> +{
> + struct riic_dev *riic = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = reset_control_deassert(riic->rstc);
> + if (ret)
> + return ret;
> +
> + ret = riic_init_hw(riic);
> + if (ret) {
> + reset_control_assert(riic->rstc);

Is this assertion really needed? It is not done when init_hw fails in
probe().

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]