Re: [PATCH v3 08/11] i2c: riic: Add support for fast mode plus

claudiu beznea
2024-08-09T07:24:16Z

On 08.08.2024 18:25, Wolfram Sang wrote:
>
>> + if (info->fast_mode_plus && t->bus_freq_hz == I2C_MAX_FAST_MODE_PLUS_FREQ)
>> + riic_clear_set_bit(riic, 0, ICFER_FMPE, RIIC_ICFER);
>
> Shouldn't that be something like
>
> t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ

You're right, it should be.

Looking though the HW manual, it specifies this about FPM bit: "Set this
bit to 1 when using the transmission rate within a range up to 1 Mbps".

Thank you,
Claudiu Beznea

>
> ? On R-Car, we have to enable the FM+ bit as soon as we exceed plain
> FastMode bus speeds.
>