Re: [PATCH v4 10/28] rust: treewide: switch to our kernel `Box` type

Danilo Krummrich
2024-08-07T23:08:20Z

On Wed, Aug 07, 2024 at 08:57:22PM +0000, Benno Lossin wrote:
> On 05.08.24 17:19, Danilo Krummrich wrote:
> > Now that we got the kernel `Box` type in place, convert all existing
> > `Box` users to make use of it.
>
> You missed a couple usages of `Box`:
> - `rust/macros/lib.rs:{242,251,281}`
> - `drivers/block/rnull.rs:{35,50}`
>
> or is that intentional? (for me rnull doesn't compile after this patch)

No, I missed them. I probably messed up my .config. I really thought I had
everything relevent enabled for compilation.

Gonna fix those.

>
> ---
> Cheers,
> Benno
>
> > Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> > ---
> > rust/kernel/init.rs | 41 ++++++++++++++++---------------
> > rust/kernel/init/__internal.rs | 2 +-
> > rust/kernel/sync/arc.rs | 17 ++++++-------
> > rust/kernel/sync/condvar.rs | 4 +--
> > rust/kernel/sync/lock/mutex.rs | 2 +-
> > rust/kernel/sync/lock/spinlock.rs | 2 +-
> > rust/kernel/workqueue.rs | 20 +++++++--------
> > 7 files changed, 44 insertions(+), 44 deletions(-)
>