Re: [PATCH 3/4] arm64: dts: qcom: x1e80100: Add UART2

Stephan Gerhold
2024-08-09T10:27:58Z

On Fri, Aug 09, 2024 at 12:24:03PM +0200, Konrad Dybcio wrote:
> On 9.08.2024 10:41 AM, Stephan Gerhold wrote:
> > On Fri, Aug 09, 2024 at 03:43:22AM +0200, Konrad Dybcio wrote:
> >> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
> >>
> >> GENI SE2 within QUP0 is used as UART on some devices, describe it.
> >>
> >> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
> >> ---
>
> [...]
>
> >
> > Can you combine these into a single entry, i.e.
> >
> > pins = "gpio8", "gpio9", "gpio10", "gpio11";
> >
> > if they are all the same?
>
> Keeping it as-is gives us
>
> a) better hw description
> b) an easier ability to add a label and change e.g. the bias
>

Ok, but it's inconsistent with what we have for qup_uart21_default right
now. I think you should either change that as well, or follow the same
pattern. :-)

Thanks,
Stephan