From: Abel Vesa <abel.vesa@linaro.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <quic_kdybcio@quicinc.com>
Subject: Re: [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets
Date: Fri, 9 Aug 2024 11:59:00 +0300 [thread overview]
Message-ID: <ZrXaVLyorJEM60ID@linaro.org> (raw)
In-Reply-To: <20240809-topic-h_sdc-v1-1-bb421532c531@quicinc.com>
On 24-08-09 02:22:04, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
>
> Remove the erroneus 0x100000 offset to prevent the boards from crashing
> on pin state setting, as well as for the intended state changes to take
> effect.
>
> Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver")
> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-x1e80100.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> index 6cd4d10e6fd6..65ed933f05ce 100644
> --- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> +++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> @@ -1805,10 +1805,10 @@ static const struct msm_pingroup x1e80100_groups[] = {
> [235] = PINGROUP(235, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [236] = PINGROUP(236, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [237] = PINGROUP(237, _, _, _, _, _, _, _, _, _),
> - [238] = UFS_RESET(ufs_reset, 0x1f9000),
> - [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1f2000, 14, 6),
> - [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1f2000, 11, 3),
> - [241] = SDC_QDSD_PINGROUP(sdc2_data, 0x1f2000, 9, 0),
> + [238] = UFS_RESET(ufs_reset, 0xf9000),
> + [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0xf2000, 14, 6),
> + [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xf2000, 11, 3),
> + [241] = SDC_QDSD_PINGROUP(sdc2_data, 0xf2000, 9, 0),
> };
>
> static const struct msm_gpio_wakeirq_map x1e80100_pdc_map[] = {
>
> ---
> base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
> change-id: 20240809-topic-h_sdc-eb6edad718cd
>
> Best regards,
> --
> Konrad Dybcio <quic_kdybcio@quicinc.com>
>
next prev parent reply other threads:[~2024-08-09 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 0:22 [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets Konrad Dybcio
2024-08-09 8:59 ` Abel Vesa [this message]
2024-08-12 2:43 ` Bjorn Andersson
2024-08-23 16:14 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrXaVLyorJEM60ID@linaro.org \
--to=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_kdybcio@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox