From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08EF9129E9C for ; Fri, 9 Aug 2024 08:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723193945; cv=none; b=TjB0Hi+0yJ4n5GzdmQuPcr4bTVTktQD1L37fc54qzil59JdwmkdguRNdLBO2gLSi6F0MPUhE+nqVUkpoBwwY9ovV1NDW++guLYGY6AX+r74GlsXTBpE3XA8RKX2Ciq7Dz6IPITKJqE7diRmAGwFRsl1bX1/gFz37JJa5f+gQa7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723193945; c=relaxed/simple; bh=lK2xl6KyTi2s5yaupefvwXgJ9xcHGS6tWSN3gQuPuBc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PA3VSEc1m/UC1o6rZPE3b3wpvzSKVr3dHtEx37Ma1c7OrMDY027kdhnF8W1Jp1lM/qFLlPSF1VxfEXNtXT0uqRIZ7nVYR+2n/aqBHlXJf6W4aQOibc0R6L2YO9g3cZcYpmZB/yNJ8AaYgFAw7gT9rQuBjpI2NNNrwKa04oPWm4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h9MN/UHR; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h9MN/UHR" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5b3fff87e6bso2032303a12.0 for ; Fri, 09 Aug 2024 01:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723193942; x=1723798742; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y29XsGoEBrWtW+8pv1a0Cy2W/65r6eteamsegCWD7+8=; b=h9MN/UHRrl/jVLDrkOl+ITEZxg/jmx54qCMb75o0gC24FGpFJdapuOp2q7RbIpT1Wg ZsjjJZ8Eo8dJM/3ggaFhYN9VDXNI1WP4bSQqH3PZHpb5UxOZMgZmkfwjR7Ba7/RbLWuz b1GuSiksgZo/zYjuVc0HiCoJC1L+7G/PG4uiXxwiFnRjhopWji7HzxdAh+aGtar4CCnk asnReYrMvU0XJC/6idTwJVFjrei1QCDLvo1oZy1/rUNvXmyrB2utkS3FI1y0AzLti0he s9kvxkjUsn33KkRB39V231/hw7fdaiR+2kzhYNcTt+h3Otvfk2dfdmaUfmKf2GWXUQzu qU+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723193942; x=1723798742; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y29XsGoEBrWtW+8pv1a0Cy2W/65r6eteamsegCWD7+8=; b=N4ZugLoDrGR17fz2r9grB+TjYeaJk2c/5fFqQwysrERjvtHtCWP+9tK+nKgkwiwbQp ufonCYGoVTzGKlZQjNozvtGVCgW5VIuU1Y/8TkaUfrbexL5Z1Y+aMmcLqkGCXr0bsAr5 1hB2tyJQQyMbp8rRZf3YbTbGbzqZ2CESikzNwYrGKBkbkM3i/oCqBuwr/8quT5rNvHS5 mngmo6In24wv90aJZMhRzrIl3jFnIdi5mHx0/1ywy5nSi1kE2lXXppBW9OfeXd/zrWqs ZMN+Sz4wcm3MV6Q2LonzcJa8i4Pe3/7PqquMxgU6zla4csJ14jVdLC3lEGTxaP8AlgEB YJmw== X-Forwarded-Encrypted: i=1; AJvYcCWfs3AaCOc1J9eqMQD20OevLTozFwlIb896Nq43goqf6r6ALQFidJeTh3rngs5hfvpj+hS00UaorC2ySjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzSJsEEXgMxHCf2buXYMfDsHIhsAw7FBLy3ANGldhqYo9KQcNRD XHJkMnCsYi1/YkpUEEarI1mXVLGnv8LhxRKwNbzBofocWzP5IJEBHrZC1uZF5NQ= X-Google-Smtp-Source: AGHT+IEm4B7KEbbYZpTWE+SXfvbTwUGi0cG0j9nLMDU4o5bCAdcyXvGo+95gVFv7Ki5MvLUURp67Fg== X-Received: by 2002:a05:6402:4408:b0:5b8:34a9:7fd8 with SMTP id 4fb4d7f45d1cf-5bd0a643fe9mr674923a12.29.1723193942195; Fri, 09 Aug 2024 01:59:02 -0700 (PDT) Received: from linaro.org ([82.79.186.176]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bbb2bf85fbsm1341522a12.16.2024.08.09.01.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 01:59:01 -0700 (PDT) Date: Fri, 9 Aug 2024 11:59:00 +0300 From: Abel Vesa To: Konrad Dybcio Cc: Bjorn Andersson , Linus Walleij , Krzysztof Kozlowski , Sibi Sankar , Marijn Suijten , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio Subject: Re: [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets Message-ID: References: <20240809-topic-h_sdc-v1-1-bb421532c531@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240809-topic-h_sdc-v1-1-bb421532c531@quicinc.com> On 24-08-09 02:22:04, Konrad Dybcio wrote: > From: Konrad Dybcio > > Remove the erroneus 0x100000 offset to prevent the boards from crashing > on pin state setting, as well as for the intended state changes to take > effect. > > Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver") > Signed-off-by: Konrad Dybcio Reviewed-by: Abel Vesa > --- > drivers/pinctrl/qcom/pinctrl-x1e80100.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c > index 6cd4d10e6fd6..65ed933f05ce 100644 > --- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c > +++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c > @@ -1805,10 +1805,10 @@ static const struct msm_pingroup x1e80100_groups[] = { > [235] = PINGROUP(235, aon_cci, qdss_gpio, _, _, _, _, _, _, _), > [236] = PINGROUP(236, aon_cci, qdss_gpio, _, _, _, _, _, _, _), > [237] = PINGROUP(237, _, _, _, _, _, _, _, _, _), > - [238] = UFS_RESET(ufs_reset, 0x1f9000), > - [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1f2000, 14, 6), > - [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1f2000, 11, 3), > - [241] = SDC_QDSD_PINGROUP(sdc2_data, 0x1f2000, 9, 0), > + [238] = UFS_RESET(ufs_reset, 0xf9000), > + [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0xf2000, 14, 6), > + [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xf2000, 11, 3), > + [241] = SDC_QDSD_PINGROUP(sdc2_data, 0xf2000, 9, 0), > }; > > static const struct msm_gpio_wakeirq_map x1e80100_pdc_map[] = { > > --- > base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179 > change-id: 20240809-topic-h_sdc-eb6edad718cd > > Best regards, > -- > Konrad Dybcio >