* [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets
@ 2024-08-09 0:22 Konrad Dybcio
2024-08-09 8:59 ` Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Konrad Dybcio @ 2024-08-09 0:22 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Abel Vesa, Krzysztof Kozlowski,
Sibi Sankar
Cc: Marijn Suijten, Rajendra Nayak, linux-arm-msm, linux-gpio,
linux-kernel, Konrad Dybcio
From: Konrad Dybcio <quic_kdybcio@quicinc.com>
Remove the erroneus 0x100000 offset to prevent the boards from crashing
on pin state setting, as well as for the intended state changes to take
effect.
Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver")
Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
---
drivers/pinctrl/qcom/pinctrl-x1e80100.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
index 6cd4d10e6fd6..65ed933f05ce 100644
--- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c
+++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
@@ -1805,10 +1805,10 @@ static const struct msm_pingroup x1e80100_groups[] = {
[235] = PINGROUP(235, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
[236] = PINGROUP(236, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
[237] = PINGROUP(237, _, _, _, _, _, _, _, _, _),
- [238] = UFS_RESET(ufs_reset, 0x1f9000),
- [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1f2000, 14, 6),
- [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1f2000, 11, 3),
- [241] = SDC_QDSD_PINGROUP(sdc2_data, 0x1f2000, 9, 0),
+ [238] = UFS_RESET(ufs_reset, 0xf9000),
+ [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0xf2000, 14, 6),
+ [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xf2000, 11, 3),
+ [241] = SDC_QDSD_PINGROUP(sdc2_data, 0xf2000, 9, 0),
};
static const struct msm_gpio_wakeirq_map x1e80100_pdc_map[] = {
---
base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
change-id: 20240809-topic-h_sdc-eb6edad718cd
Best regards,
--
Konrad Dybcio <quic_kdybcio@quicinc.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets
2024-08-09 0:22 [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets Konrad Dybcio
@ 2024-08-09 8:59 ` Abel Vesa
2024-08-12 2:43 ` Bjorn Andersson
2024-08-23 16:14 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2024-08-09 8:59 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Linus Walleij, Krzysztof Kozlowski, Sibi Sankar,
Marijn Suijten, Rajendra Nayak, linux-arm-msm, linux-gpio,
linux-kernel, Konrad Dybcio
On 24-08-09 02:22:04, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
>
> Remove the erroneus 0x100000 offset to prevent the boards from crashing
> on pin state setting, as well as for the intended state changes to take
> effect.
>
> Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver")
> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-x1e80100.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> index 6cd4d10e6fd6..65ed933f05ce 100644
> --- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> +++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> @@ -1805,10 +1805,10 @@ static const struct msm_pingroup x1e80100_groups[] = {
> [235] = PINGROUP(235, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [236] = PINGROUP(236, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [237] = PINGROUP(237, _, _, _, _, _, _, _, _, _),
> - [238] = UFS_RESET(ufs_reset, 0x1f9000),
> - [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1f2000, 14, 6),
> - [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1f2000, 11, 3),
> - [241] = SDC_QDSD_PINGROUP(sdc2_data, 0x1f2000, 9, 0),
> + [238] = UFS_RESET(ufs_reset, 0xf9000),
> + [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0xf2000, 14, 6),
> + [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xf2000, 11, 3),
> + [241] = SDC_QDSD_PINGROUP(sdc2_data, 0xf2000, 9, 0),
> };
>
> static const struct msm_gpio_wakeirq_map x1e80100_pdc_map[] = {
>
> ---
> base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
> change-id: 20240809-topic-h_sdc-eb6edad718cd
>
> Best regards,
> --
> Konrad Dybcio <quic_kdybcio@quicinc.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets
2024-08-09 0:22 [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets Konrad Dybcio
2024-08-09 8:59 ` Abel Vesa
@ 2024-08-12 2:43 ` Bjorn Andersson
2024-08-23 16:14 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2024-08-12 2:43 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Linus Walleij, Abel Vesa, Krzysztof Kozlowski, Sibi Sankar,
Marijn Suijten, Rajendra Nayak, linux-arm-msm, linux-gpio,
linux-kernel, Konrad Dybcio
On Fri, Aug 09, 2024 at 02:22:04AM GMT, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
>
> Remove the erroneus 0x100000 offset to prevent the boards from crashing
> on pin state setting, as well as for the intended state changes to take
> effect.
>
> Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver")
> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-x1e80100.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> index 6cd4d10e6fd6..65ed933f05ce 100644
> --- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> +++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> @@ -1805,10 +1805,10 @@ static const struct msm_pingroup x1e80100_groups[] = {
> [235] = PINGROUP(235, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [236] = PINGROUP(236, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [237] = PINGROUP(237, _, _, _, _, _, _, _, _, _),
> - [238] = UFS_RESET(ufs_reset, 0x1f9000),
> - [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1f2000, 14, 6),
> - [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1f2000, 11, 3),
> - [241] = SDC_QDSD_PINGROUP(sdc2_data, 0x1f2000, 9, 0),
> + [238] = UFS_RESET(ufs_reset, 0xf9000),
> + [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0xf2000, 14, 6),
> + [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xf2000, 11, 3),
> + [241] = SDC_QDSD_PINGROUP(sdc2_data, 0xf2000, 9, 0),
> };
>
> static const struct msm_gpio_wakeirq_map x1e80100_pdc_map[] = {
>
> ---
> base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
> change-id: 20240809-topic-h_sdc-eb6edad718cd
>
> Best regards,
> --
> Konrad Dybcio <quic_kdybcio@quicinc.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets
2024-08-09 0:22 [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets Konrad Dybcio
2024-08-09 8:59 ` Abel Vesa
2024-08-12 2:43 ` Bjorn Andersson
@ 2024-08-23 16:14 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2024-08-23 16:14 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Abel Vesa, Krzysztof Kozlowski, Sibi Sankar,
Marijn Suijten, Rajendra Nayak, linux-arm-msm, linux-gpio,
linux-kernel, Konrad Dybcio
On Fri, Aug 9, 2024 at 2:22 AM Konrad Dybcio <konradybcio@kernel.org> wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
>
> Remove the erroneus 0x100000 offset to prevent the boards from crashing
> on pin state setting, as well as for the intended state changes to take
> effect.
>
> Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver")
> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
Patch applied, sorry for the delay!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-23 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 0:22 [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets Konrad Dybcio
2024-08-09 8:59 ` Abel Vesa
2024-08-12 2:43 ` Bjorn Andersson
2024-08-23 16:14 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox