Re: [PATCH v4] drm/i915/hwmon: expose fan speed

Andi Shyti
2024-08-09T11:58:05Z

On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
> > Add hwmon support for fan1_input attribute, which will expose fan speed
> > in RPM. With this in place we can monitor fan speed using lm-sensors tool.
> >
> > $ sensors
> > i915-pci-0300
> > Adapter: PCI adapter
> > in0: 653.00 mV
> > fan1: 3833 RPM
> > power1: N/A (max = 43.00 W)
> > energy1: 32.02 kJ
>
> > v2:
> > - Add mutex protection
> > - Handle overflow
> > - Add ABI documentation
> > - Aesthetic adjustments (Riana)
> >
> > v3:
> > - Declare rotations as "long" and drop redundant casting
> > - Change date and version in ABI documentation
> > - Add commenter name in changelog (Riana)
> >
> > v4:
> > - Fix wakeref leak
> > - Drop switch case and simplify hwm_fan_xx() (Andi)
>
> I do not understand why we pollute Git history with changelogs, but it's
> probably the ugly atavism in DRM workflow.

I never liked it! Besides it should even be against the
submitting patches recommendation.

I don't understand what interest might have someone in a couple
of years, reading this commit, knowing an unintellegible list of
differences between v2 and v3.

I consider it a random pollution of the commit log.

Andi