Re: [PATCH v4] drm/i915/hwmon: expose fan speed

Raag Jadav
2024-08-13T11:23:21Z

On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
>
> > + /*
> > + * HW register value is accumulated count of pulses from
> > + * PWM fan with the scale of 2 pulses per rotation.
> > + */
> > + rotations = pulses >> 1;
>
> In accordance with the comment the
>
> rotations = pulses / 2;
>
> looks better.

This change seems to cause a build error in v5.
Something to do with __udivdi3 on i386.

Should we revert back to shift?

Found something similar here,
drivers/target/target_core_xcopy.c +697

Raag