Re: [PATCH v4] drm/i915/hwmon: expose fan speed

Raag Jadav
2024-08-20T09:00:34Z

On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote:
> On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
> > > Add hwmon support for fan1_input attribute, which will expose fan speed
> > > in RPM. With this in place we can monitor fan speed using lm-sensors tool.
> > >
> > > $ sensors
> > > i915-pci-0300
> > > Adapter: PCI adapter
> > > in0: 653.00 mV
> > > fan1: 3833 RPM
> > > power1: N/A (max = 43.00 W)
> > > energy1: 32.02 kJ
> >
> > > v2:
> > > - Add mutex protection
> > > - Handle overflow
> > > - Add ABI documentation
> > > - Aesthetic adjustments (Riana)
> > >
> > > v3:
> > > - Declare rotations as "long" and drop redundant casting
> > > - Change date and version in ABI documentation
> > > - Add commenter name in changelog (Riana)
> > >
> > > v4:
> > > - Fix wakeref leak
> > > - Drop switch case and simplify hwm_fan_xx() (Andi)
> >
> > I do not understand why we pollute Git history with changelogs, but it's
> > probably the ugly atavism in DRM workflow.
>
> I never liked it! Besides it should even be against the
> submitting patches recommendation.
>
> I don't understand what interest might have someone in a couple
> of years, reading this commit, knowing an unintellegible list of
> differences between v2 and v3.
>
> I consider it a random pollution of the commit log.

Isn't it already documented?
Documentation/process/submitting-patches.rst

Please put this information **after** the ``---`` line which separates
the changelog from the rest of the patch. The version information is
not part of the changelog which gets committed to the git tree. It is
additional information for the reviewers. If it's placed above the
commit tags, it needs manual interaction to remove it. If it is below
the separator line, it gets automatically stripped off when applying the
patch::

<commit message>
...
Signed-off-by: Author <author@mail>
---
V2 -> V3: Removed redundant helper function
V1 -> V2: Cleaned up coding style and addressed review comments

path/to/file | 5+++--
...

Raag
>
> Andi