Re: [PATCH v4] drm/i915/hwmon: expose fan speed

Raag Jadav
2024-08-13T12:53:33Z

On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote:
> > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
>
> ...
>
> > > > + /*
> > > > + * HW register value is accumulated count of pulses from
> > > > + * PWM fan with the scale of 2 pulses per rotation.
> > > > + */
> > > > + rotations = pulses >> 1;
> > >
> > > In accordance with the comment the
> > >
> > > rotations = pulses / 2;
> > >
> > > looks better.
> >
> > This change seems to cause a build error in v5.
> > Something to do with __udivdi3 on i386.
>
> No, it's not this change.
> Please, read report carefully.

CI seems to point to DIV_ROUND_UP(), but it's been there since v1.
So not sure if I entirely understand.

Raag