public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy@kernel.org>
To: Zhang Ning <zhangn1985@outlook.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
	linux-kernel@vger.kernel.org, lee@kernel.org
Subject: Re: mfd: intel_soc_pmic_bxtwc: irq 0 issue, tmu and typec components fail to probe.
Date: Fri, 9 Aug 2024 15:33:33 +0300	[thread overview]
Message-ID: <ZrYMne34hVa33qKf@smile.fi.intel.com> (raw)
In-Reply-To: <TY2PR01MB3322FEDCDC048B7D3794F922CDBA2@TY2PR01MB3322.jpnprd01.prod.outlook.com>

On Fri, Aug 09, 2024 at 08:02:43PM +0800, Zhang Ning wrote:
> Hi, Greg & Rafael
> 
> recently, when I try to enable mfd components for intel_soc_pmic_bxtwc
> for debian kernel[0]. I find tmu and typec failed to probe.
> 
> after check source code, I find irq for these two devices are 0, when
> use platform_get_irq, it will alway fail.
> 
> 	if (WARN(!ret, "0 is an invalid IRQ number\n"))
> 		return -EINVAL;
> 	return ret;
> 
> My workaround for debian is to hardcode irq to 0, instead to use api.
> 
> I don't know how to write a good solution, thus send an email to you.

Hold on, how the heck you got 0 in the first place?

> [0]: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1156/diffs

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-08-09 12:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 12:02 mfd: intel_soc_pmic_bxtwc: irq 0 issue, tmu and typec components fail to probe Zhang Ning
2024-08-09 12:33 ` Andy Shevchenko [this message]
2024-08-09 12:53   ` Zhang Ning
2024-08-09 14:09     ` Andy Shevchenko
2024-08-10  0:32       ` Zhang Ning
2024-08-10  5:27       ` Zhang Ning
2024-08-13  8:54         ` Greg KH
2024-09-04 14:29       ` Zhang Ning
2024-09-04 14:36         ` Andy Shevchenko
2024-09-05 11:27           ` Zhang Ning
2024-09-05 12:33             ` Andy Shevchenko
2024-09-05 14:34               ` Zhang Ning
2024-09-05 14:58               ` Zhang Ning
2024-09-24 18:02               ` Andy Shevchenko
2024-10-03 21:57         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrYMne34hVa33qKf@smile.fi.intel.com \
    --to=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=zhangn1985@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox