Re: [PATCH 06/14] arm64: dts: freescale: imx93-tqma9352-mba93xxla: improve pad configuration

Alexander Stein
2024-08-19T11:35:06Z

Hi Peng,

thanks for the review.

Am Donnerstag, 1. August 2024, 05:04:49 CEST schrieb Peng Fan:
> > Subject: [PATCH 06/14] arm64: dts: freescale: imx93-tqma9352-
> > mba93xxla: improve pad configuration
> >
> > From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> >
> > - disable PU/PD if already done with external resistors
> > - do not configure Schmitt Trigger for outputs
> > - do not configure DSE / FSEL for inputs
> > - add missing pad groups
> > - assign muxed GPIO pads for X1 to gpio2 node
> >
> > Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > .../freescale/imx93-tqma9352-mba93xxla.dts | 237 ++++++++++++----
> > --
> > 1 file changed, 164 insertions(+), 73 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-
> > mba93xxla.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-
> > mba93xxla.dts
> > index e2ee9f5a042c..c663b6585c3a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> > @@ -222,6 +222,11 @@ rtc-irq-hog {
> > };
> > };
> >
> > +&gpio2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpio2>;
>
> I am not sure this is correct, what are this used for?

This is for general GPIOs usable from userspace. I'll add a new patch for
adding gpio-line-names, so it should be clear.

> And this is new, not pad improvement.

Okay, I'll separate the changes from adding new/missing ones.

> I would prefer the other improvement part merged
> with patch 2.

Patch 2 already got merged, but despite that this patch is for the mainboard
while patch is addressing the module only.

> > +};
> > +
> > &gpio3 {
> > ethphy-eqos-irq-hog {
> > gpio-hog;
> > @@ -509,25 +514,39 @@ &usdhc2 {
> > };
> >
> > &iomuxc {
> > + pinctrl_afe: afegrp {
>
> no users?

There is no driver yet, but the pinctrl settings can still be created
meanwhile.

Thanks and best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider