From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13564923607@139.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, cameron.berkenpas@gmail.com,
tiwai@suse.de, baojun.xu@ti.com, soyer@irl.hu, Baojun.Xu@fpt.com,
robinchen@ti.com
Subject: Re: [PATCH v2] ALSA: ASoC/tas2781: fix wrong calibrated data order
Date: Tue, 13 Aug 2024 11:23:26 +0300 [thread overview]
Message-ID: <ZrsX_ry6bgDZB6bB@smile.fi.intel.com> (raw)
In-Reply-To: <20240813043749.108-1-shenghao-ding@ti.com>
On Tue, Aug 13, 2024 at 12:37:48PM +0800, Shenghao Ding wrote:
> From: Baojun Xu <baojun.xu@ti.com>
>
> Wrong calibration data order cause sound too low in some device.
> Fix wrong calibrated data order, add calibration data converssion
> by get_unaligned_be32() after reading from UEFI.
...
> rc = tasdevice_dev_bulk_write(tas_priv, i,
> TASDEVICE_REG(0, page_array[j], rgno_array[j]),
> - &(data[4 * j]), 4);
> + (unsigned char *)&data, 4);
Casting is not needed if the helper is written in a way how regmap IO accessors
done.
In any case, 4 is sizeof(data)
> + offset += 4;
Ditto.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-08-13 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 4:37 [PATCH v2] ALSA: ASoC/tas2781: fix wrong calibrated data order Shenghao Ding
2024-08-13 6:59 ` Takashi Iwai
2024-08-13 8:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrsX_ry6bgDZB6bB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13564923607@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=cameron.berkenpas@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox