From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Herve Codina <herve.codina@bootlin.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v1 1/2] irqdomain: Unify checks for bus_token
Date: Tue, 13 Aug 2024 11:58:36 +0300 [thread overview]
Message-ID: <ZrsgPHPVp7HelXkH@smile.fi.intel.com> (raw)
In-Reply-To: <87o75wrff7.ffs@tglx>
On Tue, Aug 13, 2024 at 10:32:44AM +0200, Thomas Gleixner wrote:
> On Mon, Aug 12 2024 at 22:29, Andy Shevchenko wrote:
> > The code uses if (bus_token) and if (bus_token == DOMAIN_BUS_ANY).
> > Since bus_token is enum, the later is more robust against changes.
> > Unify all checks to follow the latter variant.
> >
> > Fixes: 0b21add71bd9 ("irqdomain: Handle domain bus token in irq_domain_create()")
> > Fixes: 1bf2c9282927 ("irqdomain: Cleanup domain name allocation")
>
> I'm fine with the change per se, but what does this fix? It's correct
> code, no?
Technically yes, it's correct code as long as nobody touches the mentioned enum.
It fixes the style and makes it robust against the changes.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-13 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 19:29 [PATCH v1 0/2] irqdomain: A couple of fixes Andy Shevchenko
2024-08-12 19:29 ` [PATCH v1 1/2] irqdomain: Unify checks for bus_token Andy Shevchenko
2024-08-13 8:32 ` Thomas Gleixner
2024-08-13 8:58 ` Andy Shevchenko [this message]
2024-08-13 8:47 ` [tip: irq/core] irqdomain: Clarify " tip-bot2 for Andy Shevchenko
2024-08-13 9:41 ` [PATCH v1 1/2] irqdomain: Unify " Matti Vaittinen
2024-08-12 19:29 ` [PATCH v1 2/2] irqdomain: Remove stray '-' in the IRQ domain name Andy Shevchenko
2024-08-13 8:47 ` [tip: irq/core] irqdomain: Remove stray '-' in the " tip-bot2 for Andy Shevchenko
2024-08-13 9:46 ` [PATCH v1 2/2] irqdomain: Remove stray '-' in the IRQ " Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrsgPHPVp7HelXkH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox