From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com,
daniel@ffwll.ch, linux@roeck-us.net, andi.shyti@linux.intel.com,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
anshuman.gupta@intel.com, badal.nilawar@intel.com,
riana.tauro@intel.com, ashutosh.dixit@intel.com,
karthik.poosa@intel.com
Subject: Re: [PATCH v4] drm/i915/hwmon: expose fan speed
Date: Tue, 13 Aug 2024 15:53:25 +0300 [thread overview]
Message-ID: <ZrtXReujITKx4rHH@black.fi.intel.com> (raw)
In-Reply-To: <ZrtHz1aY_Lf_XIsL@smile.fi.intel.com>
On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote:
> > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote:
> > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote:
>
> ...
>
> > > > + /*
> > > > + * HW register value is accumulated count of pulses from
> > > > + * PWM fan with the scale of 2 pulses per rotation.
> > > > + */
> > > > + rotations = pulses >> 1;
> > >
> > > In accordance with the comment the
> > >
> > > rotations = pulses / 2;
> > >
> > > looks better.
> >
> > This change seems to cause a build error in v5.
> > Something to do with __udivdi3 on i386.
>
> No, it's not this change.
> Please, read report carefully.
CI seems to point to DIV_ROUND_UP(), but it's been there since v1.
So not sure if I entirely understand.
Raag
next prev parent reply other threads:[~2024-08-13 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 6:15 [PATCH v4] drm/i915/hwmon: expose fan speed Raag Jadav
2024-08-09 9:33 ` Nilawar, Badal
2024-08-09 10:10 ` Raag Jadav
2024-08-09 10:16 ` Andi Shyti
2024-08-14 8:37 ` Nilawar, Badal
2024-08-19 6:50 ` Raag Jadav
2024-08-19 15:22 ` Andi Shyti
2024-08-09 11:48 ` Andy Shevchenko
2024-08-09 11:57 ` Andi Shyti
2024-08-20 9:00 ` Raag Jadav
2024-08-20 21:49 ` Rodrigo Vivi
2024-08-21 3:52 ` Raag Jadav
2024-08-21 11:39 ` Andy Shevchenko
2024-08-21 11:38 ` Andy Shevchenko
2024-08-09 14:55 ` Raag Jadav
2024-08-13 11:23 ` Raag Jadav
2024-08-13 11:47 ` Andy Shevchenko
2024-08-13 12:53 ` Raag Jadav [this message]
2024-08-13 13:07 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrtXReujITKx4rHH@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=karthik.poosa@intel.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox