From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH] btrfs: update target inode's ctime on unlink
Date: Tue, 13 Aug 2024 06:27:12 -0700 [thread overview]
Message-ID: <ZrtfMK8KwSvm0I-p@infradead.org> (raw)
In-Reply-To: <20240812-btrfs-unlink-v1-1-ee5c2ef538eb@kernel.org>
On Mon, Aug 12, 2024 at 12:30:52PM -0400, Jeff Layton wrote:
> Unlink changes the link count on the target inode. POSIX mandates that
> the ctime must also change when this occurs.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Found using the nfstest_posix testsuite with knfsd exporting btrfs.
Can you also wire this up for xfstests? I suspect other file systems
might have similar issues, so running this as part of normal file system
QA would be helpful.
prev parent reply other threads:[~2024-08-13 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 16:30 [PATCH] btrfs: update target inode's ctime on unlink Jeff Layton
2024-08-12 16:42 ` David Sterba
2024-08-12 16:51 ` Jeff Layton
2024-08-13 13:00 ` David Sterba
2024-08-12 23:27 ` Qu Wenruo
2024-08-13 13:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrtfMK8KwSvm0I-p@infradead.org \
--to=hch@infradead.org \
--cc=bpf@vger.kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox