From: Petr Mladek <pmladek@suse.com>
To: takakura@valinux.co.jp
Cc: rostedt@goodmis.org, john.ogness@linutronix.de,
senozhatsky@chromium.org, akpm@linux-foundation.org,
bhe@redhat.com, lukas@wunner.de, wangkefeng.wang@huawei.com,
ubizjak@gmail.com, feng.tang@intel.com, j.granados@samsung.com,
stephen.s.brennan@oracle.com, linux-kernel@vger.kernel.org,
nishimura@valinux.co.jp, taka@valinux.co.jp
Subject: Re: [PATCH v3 1/2] Allow cpu backtraces to be written into ringbuffer during panic
Date: Tue, 13 Aug 2024 15:48:33 +0200 [thread overview]
Message-ID: <ZrtkMciiYhUK8Fs4@pathway.suse.cz> (raw)
In-Reply-To: <20240812072703.339690-1-takakura@valinux.co.jp>
On Mon 2024-08-12 16:27:03, takakura@valinux.co.jp wrote:
> From: Ryo Takakura <takakura@valinux.co.jp>
>
> commit 779dbc2e78d7 ("printk: Avoid non-panic CPUs writing
> to ringbuffer") disabled non-panic CPUs to further write messages to
> ringbuffer after panicked.
>
> Since the commit, non-panicked CPU's are not allowed to write to
> ring buffer after panicked and CPU backtrace which is triggered
> after panicked to sample non-panicked CPUs' backtrace no longer
> serves its function as it has nothing to print.
>
> Fix the issue by allowing non-panicked CPUs to write into ringbuffer
> while CPU backtrace is in flight.
>
> Fixes: 779dbc2e78d7 ("printk: Avoid non-panic CPUs writing to ringbuffer")
> Signed-off-by: Ryo Takakura <takakura@valinux.co.jp>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
JFYI, I have pushed this patch into printk/linux.git, branch for-6.11-fixup.
I am going to create pull request after it spends at least one or two
days in linux-next.
The 2nd patch is more complicated. It depends on another patchset
integrating con->write_atomic() callback.
Best Regards,
Petr
next prev parent reply other threads:[~2024-08-13 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 7:21 [PATCH v3 0/2] printk: CPU backtrace not printing on panic takakura
2024-08-12 7:27 ` [PATCH v3 1/2] Allow cpu backtraces to be written into ringbuffer during panic takakura
2024-08-13 13:48 ` Petr Mladek [this message]
2024-08-15 10:41 ` takakura
2024-08-12 7:29 ` [PATCH v3 2/2] Handle flushing of CPU backtraces " takakura
2024-08-13 13:45 ` Petr Mladek
2024-08-15 10:43 ` takakura
2024-08-19 19:23 ` John Ogness
2024-08-21 5:02 ` takakura
2024-08-26 15:46 ` John Ogness
2024-08-31 8:20 ` takakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrtkMciiYhUK8Fs4@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=feng.tang@intel.com \
--cc=j.granados@samsung.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=nishimura@valinux.co.jp \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=stephen.s.brennan@oracle.com \
--cc=taka@valinux.co.jp \
--cc=takakura@valinux.co.jp \
--cc=ubizjak@gmail.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox