From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Kajol Jain <kjain@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf disasm: Fix memory leak for locked operations
Date: Tue, 13 Aug 2024 11:53:01 -0300 [thread overview]
Message-ID: <ZrtzTTHim_vGX1ma@x1> (raw)
In-Reply-To: <20240813040613.882075-1-irogers@google.com>
On Mon, Aug 12, 2024 at 09:06:12PM -0700, Ian Rogers wrote:
> lock__parse calls disasm_line__parse passing
> &ops->locked.ins.name. Ensure ops->locked.ins.name is freed in
> lock__delete.
>
> Found with lock/leak sanitizer.
Applied both patches to perf-tools-next.
Thanks,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/disasm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c
> index 22289003e16d..226d2181f694 100644
> --- a/tools/perf/util/disasm.c
> +++ b/tools/perf/util/disasm.c
> @@ -566,6 +566,7 @@ static void lock__delete(struct ins_operands *ops)
> ins_ops__delete(ops->locked.ops);
>
> zfree(&ops->locked.ops);
> + zfree(&ops->locked.ins.name);
> zfree(&ops->target.raw);
> zfree(&ops->target.name);
> }
> --
> 2.46.0.76.ge559c4bf1a-goog
next prev parent reply other threads:[~2024-08-13 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 4:06 [PATCH v1 1/2] perf disasm: Fix memory leak for locked operations Ian Rogers
2024-08-13 4:06 ` [PATCH v1 2/2] perf test annotate: Dump trapping test in trap handler Ian Rogers
2024-08-13 14:53 ` Arnaldo Carvalho de Melo [this message]
2024-08-13 16:04 ` [PATCH v1 1/2] perf disasm: Fix memory leak for locked operations Ian Rogers
2024-08-13 18:10 ` Arnaldo Carvalho de Melo
2024-08-13 19:11 ` Ian Rogers
2024-08-13 20:41 ` Arnaldo Carvalho de Melo
2024-08-13 22:25 ` Namhyung Kim
2024-08-14 0:43 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrtzTTHim_vGX1ma@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox