From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F3454918 for ; Tue, 13 Aug 2024 16:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723567729; cv=none; b=di78Kpb4RKIhjtYhinGHH2PTiaFK5fUUOZoD5YNMr7+XIA9Nxfl0ofEhOFV+49HCTgGEdyMn1OmvGBcBs38Q1qwOhkZ7dydZMY8pyAn8xugtfCra+YYRZSZXQEx2dNMdoH6eWb1sY9CKHyOQ1md1z5UOmELuWdC42EF/Zuw2ah8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723567729; c=relaxed/simple; bh=AbyZZV8OemEO6yQWBbj90k325MRdx2HrxlcMri6YGQA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WbsMm3AyKz+k3cXSicP/63396lNkmC9O+vIMcCCwnI+LNH0s4OS4Wn72TPkoYBqFVEknz7D6M5mwpLCmfM0CUXha5ABzgT8Bdw3lebn90fm9L5AMoarazHaVEXUQzBgBfBsyuNfCGI/1CZZGG5uPcCG64A6X2zoz/ImUTqhuG7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=XllG348N; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XllG348N" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1fc587361b6so47150525ad.2 for ; Tue, 13 Aug 2024 09:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723567728; x=1724172528; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1B3Gf2ESIqFOuwatjJBDFN+ZmaA9cH3bs2DrpeTPuZQ=; b=XllG348NuaTu/X87n6jTIxZq70C5aISv91H7hAhFrpQo8n0k7iHgQY2ikxQGQUn6Dy rUhjJO3Pfx8f1jNV5iMZjbRgCtFf7Vj2MpF5u5fG5mtUao5nkJOiX5IxUqWfKcsoY64G X20ZoLOyC8qnhRVyzbqmPswAZZl9xe/FzffzI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723567728; x=1724172528; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1B3Gf2ESIqFOuwatjJBDFN+ZmaA9cH3bs2DrpeTPuZQ=; b=s/xByRTPgd602I2os6/by5ooP/78mSjFeNCWvqiwe0qfKAzdNIizLQmdQ99GWO5HmS cjSP8NlURC0QS+8WhSQ5RD/09z7DPeedM+i1IYpHDz8elLLptPvuXUxU4Kbbwg0ueMmP TUVf85jzf36h56L+CfleR2eJvG64tp+cW8ggaq9X+AUgnN3m4ikqgG6uWn3h66qUqEWA T/DIlIR1ytPG1ChTJRm3F0+70YQdhKRNlpPPz7Gvd0nKq2Und3ebOs4M6/IkLgl14niQ ELs0ImpJImdfCskXwxijg0hriW8DU7Qgkyx/3jtERfc7uQFuXnpiLnHb+bPNbp6xUeJp Q+SA== X-Forwarded-Encrypted: i=1; AJvYcCWYk0NgloEZ2QA38ysEbiG3ameR7Z0R1DrrOH4sc+B7uIHPCeKxRZiE+b4NmT05YS9BknCxtYnpunMqJeTGCFiuagkijQmsGSgGtKBp X-Gm-Message-State: AOJu0Yzr4Y9EVV2bB4Mk6ScfWYXhi2NqP/M1fINzXSJ6HBK7DD68yi0/ taKae+5TcWZl3BYABorcKTsVcFk2VXl4Z9dSfo3G13fQ2Sgvpn2HdQUgNMvcpg== X-Google-Smtp-Source: AGHT+IEj0wPMiW8kmdwXC1HxDPUfbMhHQQB3MyjLItlZspVvqa8S7vnINZrGuQzEF1UyzVq2TpavBA== X-Received: by 2002:a17:903:32c2:b0:1fc:6ebf:9092 with SMTP id d9443c01a7336-201d64e85e5mr1012705ad.57.1723567727726; Tue, 13 Aug 2024 09:48:47 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:45ad:979d:1377:77f0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-201cd1a9389sm15752865ad.135.2024.08.13.09.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 09:48:47 -0700 (PDT) Date: Tue, 13 Aug 2024 09:48:46 -0700 From: Brian Norris To: Sascha Hauer Cc: Francesco Dolcini , Kalle Valo , David Lin , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] wifi: mwifiex: keep mwifiex_cfg80211_ops constant Message-ID: References: <20240809-mwifiex-duplicate-mwifiex_cfg80211_ops-v1-1-23e0e6290ace@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240809-mwifiex-duplicate-mwifiex_cfg80211_ops-v1-1-23e0e6290ace@pengutronix.de> On Fri, Aug 09, 2024 at 11:51:48AM +0200, Sascha Hauer wrote: > With host_mlme support being added mwifiex_cfg80211_ops is no longer > constant, but supplemented with the host_mlme related ops when host_mlme > support is enabled. This doesn't work with multiple adapters when only > few of then have host_mlme support. Duplicate mwifiex_cfg80211_ops > before using it and keep the original constant. > > While at it mark mwifiex_cfg80211_ops const to prevent people from > changing it again during runtime. > > Fixes: 36995892c271c ("wifi: mwifiex: add host mlme for client mode") > Signed-off-by: Sascha Hauer Acked-by: Brian Norris