public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sunil V L <sunilvl@ventanamicro.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 0/7] serial: 8250_platform: refactor and clean up a bit
Date: Wed, 14 Aug 2024 11:58:59 +0530	[thread overview]
Message-ID: <ZrxOq2177rnZXZ1b@sunil-laptop> (raw)
In-Reply-To: <20240812154901.1068407-1-andriy.shevchenko@linux.intel.com>

On Mon, Aug 12, 2024 at 06:47:02PM +0300, Andy Shevchenko wrote:
> Recent patch against this driver has been added without my review.
> It was technically my fault, however I was on long vacation.
> So, instead of blaming anyone, this small series to tidy up the things
> as I think would look and be maintainable better.
> 
> Andy Shevchenko (7):
>   serial: 8250_platform: Remove duplicate mapping
>   serial: 8250_platform: Don't shadow error from
>     serial8250_register_8250_port()
>   serial: 8250_platform: Use same check for ACPI in the whole driver
>   serial: 8250_platform: Tidy up ACPI ID table
>   serial: 8250_platform: Switch to use platform_get_mem_or_io()
>   serial: 8250_platform: Refactor serial8250_probe()
>   serial: 8250_platform: Unify comment style
> 
>  drivers/tty/serial/8250/8250_platform.c | 107 +++++++++++++-----------
>  1 file changed, 58 insertions(+), 49 deletions(-)
> 
Nice!. Thank you very much!.

For the series:

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Tested-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks!
Sunil

      parent reply	other threads:[~2024-08-14  6:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 15:47 [PATCH v1 0/7] serial: 8250_platform: refactor and clean up a bit Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 1/7] serial: 8250_platform: Remove duplicate mapping Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 2/7] serial: 8250_platform: Don't shadow error from serial8250_register_8250_port() Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 3/7] serial: 8250_platform: Use same check for ACPI in the whole driver Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 4/7] serial: 8250_platform: Tidy up ACPI ID table Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 5/7] serial: 8250_platform: Switch to use platform_get_mem_or_io() Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 6/7] serial: 8250_platform: Refactor serial8250_probe() Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 7/7] serial: 8250_platform: Unify comment style Andy Shevchenko
2024-08-14  6:28 ` Sunil V L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrxOq2177rnZXZ1b@sunil-laptop \
    --to=sunilvl@ventanamicro.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox