From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB3D71A0715 for ; Tue, 27 Aug 2024 13:37:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724765864; cv=none; b=WrD0mW+sv/+02Hnp68lIQYbUcyWHnx9RgC9hLAOQlUc2d16k3x/35LB1c8qrvBfYQZKxqWKaa1HA9CzjjtdU/xB11keAUkj/2zJqOZJNXCMEQjsO9kb6zAkfKXCYFPxhilYML/TP8lKcb6VF9FJ0v3YkDSooNvQnycVhO69mxz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724765864; c=relaxed/simple; bh=wXsFWmD5dBtUKOpD/T8KdCEFMfFAVqUNboZ9+9Off0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gIXwEDfqhdgQWwEZLh3gl2rqv2rCsSpg40P1F1AG4omyLH7DH2n18oMB43h2Rpi2mVZVh5e0OJukIaeJcM8y7KXNUt0dk5umrXlspydt/0lYnlmPYLd+LMjexmH4sjpJdH8yTWRu41qsSVp9ZiBwLpKYK8vXu1n6ij+yuOhFSas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bk04D5LQ; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bk04D5LQ" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-53345dcd377so7334658e87.2 for ; Tue, 27 Aug 2024 06:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724765860; x=1725370660; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AT4VXmb4R9vLR4EZHGzi0KQ518kZdDJ1Wc7PbdyET90=; b=bk04D5LQumPJQrJeVrYScMfKlYwwb8Hn/9maV2wbNo1daMNdFCpZ7g7JgjNyoXrdYr SU7OLIGEphcDAsnVtyDUXYw9w4sfot90BYiUKoKA4UamQIM7X0w1ScqQ9sbW5HANloa3 0599YvGCiRxG7yADvCFhchX12dTWdkYNY5aWsjfWrgZIvH1frklOYIYgJiaEOsY/+Z4U 0jVLPFYRSHsOUjqkUiclmj2rTD0QpAQxJjhYtA3+k/XmMbvdT6StNGddMGcTwaPF3kWv 5MsmqE0jhC0Dh5Ymc5MWZIcZl+nbj7lW5Oo/nab7QszNtH4xlJt3n3Vfv9BlJZKIio+Y c7pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724765860; x=1725370660; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AT4VXmb4R9vLR4EZHGzi0KQ518kZdDJ1Wc7PbdyET90=; b=deMw94HgqI+ozuYAqa3VBOZxHoEZtRc0x6SAJ7O+wZsGNanfWKM8sjcfjQ/71OvO2M DZFj1ivID/IYrva9jBPi/a1DRUMVNo2qDzGqS3nVhYNZNAs/qWgeX1g1T96Cvyc1h9lU 7FhbmopYU5FjCzExuZ89O/72iBJSU7zTHUKAA8hMF8t+lILA/R6qJY3fm4Wy4IBVIwpc kU8oxJZTx4VcFae7KlzBAG6NHYFaT/FwxIhY/Lm8D5V3QQ0tjGh2SgqYoAXLQHuoV7AW 1+OkGowQvEL6LxSbYXJNVgU/daDgeWj2AGesqs4+hYMueY5EidCT0/seOdIEVBxawQtL rO9A== X-Forwarded-Encrypted: i=1; AJvYcCVuS8u3lgci4ZGjcOldjEK0XkJpUUq8NevMdHhBiao+TVn7Lm+Z099BvanOktuLIbLIz+Xuu3a1/efKLqA=@vger.kernel.org X-Gm-Message-State: AOJu0YxQkoXhfFv1sSfCfqe/swD9n/pww/SSV7tFsGn4NL499c1rLYL2 mqbjaPqOKf6pE5vYsA94oa4KNhaSW22bqEZbbxQD0uj5OhB3JFkUdKmcwi43LBU= X-Google-Smtp-Source: AGHT+IHLZaTBk7t7Tm5sDsRxPVC4MnBBYf4HikHA9gnfnsCOTEJ+b/dFLLVXn/7+6yLZPfm13I9ibA== X-Received: by 2002:a05:651c:b1f:b0:2ef:2b53:c77e with SMTP id 38308e7fff4ca-2f4f48d605dmr94846181fa.7.1724765859849; Tue, 27 Aug 2024 06:37:39 -0700 (PDT) Received: from localhost (109-81-92-122.rct.o2.cz. [109.81.92.122]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c0bb1c2d45sm1029610a12.12.2024.08.27.06.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 06:37:39 -0700 (PDT) Date: Tue, 27 Aug 2024 15:37:38 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: Hailong Liu , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 27-08-24 14:47:30, Uladzislau Rezki wrote: > On Tue, Aug 27, 2024 at 08:49:35AM +0200, Michal Hocko wrote: [...] > > > 2. High-order allocations. Do you think we should not care much about > > > it when __GFP_NOFAIL is set? Same here, there is a fallback for order-0 > > > if "high" fails, it is more likely NO_FAIL succeed for order-0. Thus > > > keeping NOFAIL for high-order sounds like not a good approach to me. > > > > We should avoid high order allocations with GFP_NOFAIL at all cost. > > > What do you propose here? Fail such request? We shouldn't have any hard requirements for higher order allocations in the vmalloc right? In other words we can always fallback to base pages. -- Michal Hocko SUSE Labs