public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Woody Suwalski <terraluna977@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mouse_cypress_ps2: Fix 6.11 regression on xps15z
Date: Tue, 27 Aug 2024 18:10:25 -0700	[thread overview]
Message-ID: <Zs55AWhUEts-uJ5B@google.com> (raw)
In-Reply-To: <a8252e0f-dab4-ef5e-2aa1-407a6f4c7204@gmail.com>

Hi Woody,

On Tue, Aug 27, 2024 at 07:44:12PM -0400, Woody Suwalski wrote:
> Kernel 6.11 rcN on Dell XPS 15Z:  touch pad has stopped working after the
> patch
> 
> commit 8bccf667f62a2351fd0b2a2fe5ba90806702c048
> Author: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Date:   Fri Jun 28 15:47:25 2024 -0700
> 
>     Input: cypress_ps2 - report timeouts when reading command status
> 
> It seems that the first communication is with an invalid packet of 3 NULLs,
> and that
> status failure used to be ignored. With the above patch it is now returning
> an error and
> that results in a dead touch pad.
> 
> The fix is to stop flagging an error for 3-byte null packets, just keep
> ignoring them as before.
> [    2.338016] [    T591] err: Command 0x00 response data (0x): 00 00 00
> [    2.338032] [    T591] ok: Command 0x00 response data (0x): 33 cc a2
> ...
> [    2.770029] [    T591] ok: Command 0x00 response data (0x): 33 cc a2
> [    2.998030] [    T591] ok: Command 0x11 response data (0x): 01 00 64

Could you please send me logs with i8042.debug=1 kernel command line
option please?  I wonder if we need to wake up the controller...

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-08-28  1:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 23:44 [PATCH] mouse_cypress_ps2: Fix 6.11 regression on xps15z Woody Suwalski
2024-08-28  1:10 ` Dmitry Torokhov [this message]
2024-08-28  2:46   ` Woody Suwalski
2024-08-28 19:15     ` Dmitry Torokhov
2024-08-28 20:57       ` Dmitry Torokhov
2024-08-29  2:18         ` Woody Suwalski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zs55AWhUEts-uJ5B@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=terraluna977@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox