From: Baoquan He <bhe@redhat.com>
To: Will Deacon <will@kernel.org>
Cc: k-hagio-ab@nec.com, lijiang@redhat.com,
Kuan-Ying Lee <kuan-ying.lee@canonical.com>,
Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ardb@kernel.org
Subject: Re: [PATCH] arm64/vmcore: Add pgtable_l5_enabled information in vmcoreinfo
Date: Wed, 28 Aug 2024 06:48:03 +0800 [thread overview]
Message-ID: <Zs5Xo5eVUvGMbtSv@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20240827122459.GA4679@willie-the-truck>
On 08/27/24 at 01:24pm, Will Deacon wrote:
> On Mon, Aug 26, 2024 at 02:52:02PM +0800, Kuan-Ying Lee wrote:
> > Since arm64 supports 5-level page tables, we need to add this
> > information to vmcoreinfo to make debug tools know if 5-level
> > page table is enabled or not.
> >
> > Missing this information will break the debug tool like crash [1].
> >
> > [1] https://github.com/crash-utility/crash
> >
> > Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
> > ---
> > Documentation/admin-guide/kdump/vmcoreinfo.rst | 6 ++++++
> > arch/arm64/kernel/vmcore_info.c | 3 +++
> > 2 files changed, 9 insertions(+)
>
> In which case, wouldn't you also want to know about pgtable_l4_enabled()?
That is a good question. I guess it's deduced in code, mostly needed for
different PAGE_OFFSET, how to transfer virtual addr to physical addr,
etc.
Add Crash utility experts here.
next prev parent reply other threads:[~2024-08-27 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 6:52 [PATCH] arm64/vmcore: Add pgtable_l5_enabled information in vmcoreinfo Kuan-Ying Lee
2024-08-27 12:24 ` Will Deacon
2024-08-27 22:48 ` Baoquan He [this message]
[not found] ` <CANU+ZydbFPiSnCRr3qQ52GjUQQmU3ZO62c6hRkoLM147+u5u8w@mail.gmail.com>
2024-08-30 6:41 ` Kuan-Ying Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs5Xo5eVUvGMbtSv@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
--cc=kuan-ying.lee@canonical.com \
--cc=lijiang@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox