Re: [PATCH 2/5] xfs: move the tagged perag lookup helpers to xfs_icache.c

Christoph Hellwig
2024-08-22T03:47:40Z

On Wed, Aug 21, 2024 at 09:34:07AM -0700, Darrick J. Wong wrote:
> On Wed, Aug 21, 2024 at 08:38:29AM +0200, Christoph Hellwig wrote:
> > The tagged perag helpers are only used in xfs_icache.c in the kernel code
> > and not at all in xfsprogs. Move them to xfs_icache.c in preparation for
> > switching to an xarray, for which I have no plan to implement the tagged
> > lookup functions for userspace.
>
> I don't particularly like moving these functions to another file, but I
> suppose the icache is the only user of these tags. How hard is it to
> make userspace stubs that assert if anyone ever tries to use it?

It might be easier to just implement them in that case like the underlying
radix tree ones. But given that they are unused I'd feel rather
uncomfortable about it. And more importantly I like to have the
function (only one is left by the end) close to the callers as that makes
reading and understanding the code easier.