Re: [PATCH 2/5] xfs: move the tagged perag lookup helpers to xfs_icache.c

Christoph Hellwig
2024-08-28T06:28:50Z

On Wed, Aug 21, 2024 at 09:34:07AM -0700, Darrick J. Wong wrote:
> I don't particularly like moving these functions to another file, but I
> suppose the icache is the only user of these tags. How hard is it to
> make userspace stubs that assert if anyone ever tries to use it?

I looked into not moving them, but the annoying thing is that we then
need to make the ici_tag_to_mark helper added later and the marks
global. Unless this is a blocker for you I'd much prefer to just
keep all the tag/mark logic contained in icache.c for now. Things
might change a bit if/when we do the generic xfs_group and also use
tags for garbage collection of zoned rtgs, but I'd rather build the
right abstraction when we get to that. That will probably also
include sorting out the current mess with the ICI vs IWALK flags.