From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D15FA3D96A for ; Wed, 28 Aug 2024 04:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724820666; cv=none; b=N2fPqQu/uNlwetpYNJxHWe7v6Fep3U3htYOwB+qCReV6zg6clOxEom2BvIbe9KaElSO48grWVSTH506OFhn8TB5sShaCOhwRfqwRkf37rz/XJ4RHUHGgNBxr3v6FXyQ7edUpk6Q/agtOYGogCW4ebuLNgM4HfoZr3aLKLOY7Wfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724820666; c=relaxed/simple; bh=mC9LMTWSpFcuIJEu28ZZ2VhcDn6OzdsBY8UEHYOb20Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ckHImOCri4ePkcyDvTCW0F2oVQMmtjyMwc6ifOVWDMWpwCMzyaAr3gB9pG+iNp/5HtVVTAzO/n1FFTMedUh665IJm1eAWsqOlPGFK6lQdS3KdZubWA2fofScG0ApOqLRQDZlAojUtvSY8G91fD+iR4UMr/I6luaruAmHrqVHG74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sjAds-0007LE-UW; Wed, 28 Aug 2024 06:50:48 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sjAdq-003akd-KX; Wed, 28 Aug 2024 06:50:46 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sjAdq-00Ahtu-1f; Wed, 28 Aug 2024 06:50:46 +0200 Date: Wed, 28 Aug 2024 06:50:46 +0200 From: Oleksij Rempel To: Jakub Kicinski Cc: Andrew Lunn , netdev@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Eric Dumazet , kernel@pengutronix.de, Paolo Abeni , "David S. Miller" , Heiner Kallweit Subject: Re: [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics Message-ID: References: <20240822115939.1387015-1-o.rempel@pengutronix.de> <20240822115939.1387015-2-o.rempel@pengutronix.de> <20240826093217.3e076b5c@kernel.org> <4a1a72f5-44ce-4c54-9bc5-7465294a39fe@lunn.ch> <20240826125719.35f0337c@kernel.org> <20240827113300.08aada20@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240827113300.08aada20@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Tue, Aug 27, 2024 at 11:33:00AM -0700, Jakub Kicinski wrote: > On Tue, 27 Aug 2024 06:51:27 +0200 Oleksij Rempel wrote: > > I completely agree with you, but I currently don't have additional > > budget for this project. > > Is this a legit reason not to do something relatively simple? Due to the nature of my work in a consulting company, my time is scheduled across multiple customers. For the 10BaseT1 PHY, I had 2 days budgeted left, which allowed me to implement some extra diagnostics. This was simple, predictable, and within the scope of the original task. However, now that the budget for this task and customer has been used up, any additional work would require a full process: - I would need to sell the idea to the customer. - The new task would need to be prioritized. - It would then be scheduled, which could happen this year, next year, or possibly never. A similar situation occurred with the EEE implementation. I started with a simple fix for Atheros PHY's SmartEEE, but it led to reworking the entire EEE infrastructure in the kernel. Once the budget was exhausted, I couldn’t continue with SmartEEE for Atheros PHYs. These are the risks inherent to consulting work. I still see it as not wasted time, because we have a better EEE infrastructure now. Considering that you've requested a change to the uAPI, the work has now become more predictable. I can plan for it within the task and update the required time budget accordingly. However, it's worth noting that while this work is manageable, the time spent on this particular task could be seen as somewhat wasted from a budget perspective, as it wasn't part of the original scope. > Especially that we're talking about uAPI, once we go down > the string path I presume they will stick around forever. Yes, I agree with it. I just needed this feedback as early as possible. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |