From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E3F2747B for ; Wed, 28 Aug 2024 18:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724869233; cv=none; b=iiCwNv629b4n5MUB75Uq03uvJ1idqyZTccxrP6+k0VClOhdW4njWmssG+S6iYYncX34zacxkCXbSZUNFbENib+c6vJx5xqiyhbCKii668sby3LH/oCMik1e2qkkbdZqCpGxNOlnWQ6FkAecq8Dh8G6pvIBOqYu9G8wRjp0tWOTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724869233; c=relaxed/simple; bh=GfsT+vvYha7T/tdivOawOneMSln9lfsX+bYPVQCgdao=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=EYn86vhjRLqn5KPIzagkwsvSBn6gbJot7WrV6IMNy0ebN+6UMXWMqou9PhuF2mhGwUXXLzA7VScYNemVhMmwRTKFtRP8aKX9XDFMhM1nFk4qVpGw4sRcJ6oDQAdLOq6zfWAjSSkQEhsTy+HWE5g4jHmplS/TEOvrb2ohbrLa+xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PwQHV71d; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PwQHV71d" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1fd6d695662so79137845ad.0 for ; Wed, 28 Aug 2024 11:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724869232; x=1725474032; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=E9QORzkbaaIm1Shd59RkljU3nACF4RVEs75Qe6yztVA=; b=PwQHV71dJo8Hu29+3dQ9VAHC9j7de9FC5teCZRnA3qqAXfYz/tCBCfI5d9Hwax47YP u77n/1tcTkc0uNOh00/SnlNmKGpw+mvVCU45+w8kWn2OHOQGy9gDxr7f1FAHK4dqnozT Q+tb6dytGFtMYq9fYU0jNO3lllgvlOhKomWBZM/IuqSMczS9ALMNib4wJqXtxAI8py5u hsghv72+bre50Yfs78spO9kuRlmXC+Xz0HRLgoEkw/3DGwaA+/mmgdRAm/eZZ1dG3FdQ 8W3cRIhIiT5xTo4o0javEiDrzi4curUS95SvOhkyPFc6JFKIHCwPwcUNYeJZXy5yKBal bsvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724869232; x=1725474032; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E9QORzkbaaIm1Shd59RkljU3nACF4RVEs75Qe6yztVA=; b=PzsBAmBH74afGL7wHMSWjEBTDCYMCLQjBpCUOlR9rjGZNFb+r5tJYcTNe+bvgvYIZj VsZS4vq0/3RDgsno+80JhbfuNSTc+qcB55VfPNdp/n++OQlfQMJHKfYYyLAhh3cUcrpq bc3d8+Oy2yqR6TSw7oSEWAl8AdFfGdbSAoQC3IQ8CneulCfSVxTsQ8SyXxjUiyV9eWqA c6mh86QKx3BznF+Le8OXjKSzEWtqnAtwTF+JXfniOyy1VsukWjjY6zHYTyRiXAxJSyQQ WhyZnaA8Z17hZ9rvuJoSkRSC5YwtBD0XrNv8kndNZ6cQW2rocvA919fp6NI60hTQO1G4 90OQ== X-Forwarded-Encrypted: i=1; AJvYcCVAZH/UpPS8X6VQAHSnTmEqwzB3/krp/qqrYr/Ekt/o6tYnqoCQoR1cElo6K6TKc4eYAqdCEOHWGarBDm4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8tSJ8R8gjsF4nnsY7S471/j6oLAUTClZUohLvKI+/bC9XMV17 mdiqBRKF3tjwj4+hPXDzuwln5TFsHZH67C54/aN98dS4+5g77zwejc/RKdZxTyTmEoiCP4sQ0mN IJw== X-Google-Smtp-Source: AGHT+IGmEH4zsz+BBfnZFRtoj4ShHcKA/Dy+MAP5E3wD0XLVVVClTEOGYDvwZFejqOumhasfY16ODgvgScg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:db11:b0:202:2fc8:da23 with SMTP id d9443c01a7336-2050c3437e9mr230455ad.5.1724869231597; Wed, 28 Aug 2024 11:20:31 -0700 (PDT) Date: Wed, 28 Aug 2024 11:20:30 -0700 In-Reply-To: <20240809194335.1726916-11-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240809194335.1726916-1-seanjc@google.com> <20240809194335.1726916-11-seanjc@google.com> Message-ID: Subject: Re: [PATCH 10/22] KVM: x86/mmu: Move walk_slot_rmaps() up near for_each_slot_rmap_range() From: Sean Christopherson To: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Upton , Marc Zyngier , Peter Xu , James Houghton Content-Type: text/plain; charset="us-ascii" On Fri, Aug 09, 2024, Sean Christopherson wrote: > Move walk_slot_rmaps() and friends up near for_each_slot_rmap_range() so > that the walkers can be used to handle mmu_notifier invalidations, and so > that similar function has some amount of locality in code. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/mmu/mmu.c | 107 +++++++++++++++++++++-------------------- > 1 file changed, 54 insertions(+), 53 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index 901be9e420a4..676cb7dfcbf9 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -1534,6 +1534,60 @@ static void slot_rmap_walk_next(struct slot_rmap_walk_iterator *iterator) > slot_rmap_walk_okay(_iter_); \ > slot_rmap_walk_next(_iter_)) > > + Doh, extra newline here. > +/* The return value indicates if tlb flush on all vcpus is needed. */ > +typedef bool (*slot_rmaps_handler) (struct kvm *kvm, > + struct kvm_rmap_head *rmap_head, > + const struct kvm_memory_slot *slot); > +