Re: [PATCH 2/3] soundwire: intel: increase maximum number of links

[Vinod Koul <vkoul@kernel.org>]

On 16-08-24, 10:33, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> Intel platforms have enabled 4 links since the beginning, newer
> platforms now have 5 links. Update the definition accordingly.
> 
> This patch will have no effect on older platforms where the number of
> links was hard-coded. A follow-up patch will add a dynamic check that
> the ACPI-reported information is aligned with hardware capabilities on
> newer platforms.

Should this not be the third patch, the dynamic check in 3rd should come
before otherwise your older platforms might break?


Other than order lgtm:

Acked-by: Vinod Koul <vkoul@kernel.org>


> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> ---
>  include/linux/soundwire/sdw_intel.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/soundwire/sdw_intel.h b/include/linux/soundwire/sdw_intel.h
> index 87d82ea9a13a..edbe1d4af8f8 100644
> --- a/include/linux/soundwire/sdw_intel.h
> +++ b/include/linux/soundwire/sdw_intel.h
> @@ -450,6 +450,6 @@ extern const struct sdw_intel_hw_ops sdw_intel_lnl_hw_ops;
>  /*
>   * Max number of links supported in hardware
>   */
> -#define SDW_INTEL_MAX_LINKS                4
> +#define SDW_INTEL_MAX_LINKS                5
>  
>  #endif
> -- 
> 2.43.0