From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: hdegoede@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] i8042: Add forcenorestore quirk to leave controller untouched even on s3
Date: Sun, 18 Aug 2024 21:31:42 -0700 [thread overview]
Message-ID: <ZsLKrnnsc1rh2KxW@google.com> (raw)
In-Reply-To: <20240104183118.779778-2-wse@tuxedocomputers.com>
On Thu, Jan 04, 2024 at 07:31:17PM +0100, Werner Sembach wrote:
> On s3 resume the i8042 driver tries to restore the controller to a known
> state by reinitializing things, however this can confuse the controller
> with different effects. Mostly occasionally unresponsive keyboards after
> resume.
>
> These issues do not rise on s0ix resume as here the controller is assumed
> to preserved its state from before suspend.
>
> This patch adds a quirk for devices where the reinitialization on s3 resume
> is not needed and might be harmful as described above. It does this by
> using the s0ix resume code path at selected locations.
>
> This new quirk goes beyond what the preexisting reset=never quirk does,
> which only skips some reinitialization steps.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: stable@vger.kernel.org
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2024-08-19 4:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 18:31 [PATCH v4 0/2] i8042: Add forcenorestore quirk to leave controller Werner Sembach
2024-01-04 18:31 ` [PATCH v4 1/2] i8042: Add forcenorestore quirk to leave controller untouched even on s3 Werner Sembach
2024-01-05 19:38 ` Hans de Goede
2024-01-09 21:48 ` Dmitry Torokhov
2024-01-10 13:51 ` Werner Sembach
2024-08-09 16:49 ` Werner Sembach
2024-08-19 4:31 ` Dmitry Torokhov [this message]
2024-01-04 18:31 ` [PATCH v4 2/2] i8042: Use new forcenorestore quirk to replace old buggy quirk combination Werner Sembach
2024-01-05 19:38 ` Hans de Goede
2024-08-19 4:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsLKrnnsc1rh2KxW@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox