From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 630E915CD75 for ; Mon, 19 Aug 2024 14:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724077149; cv=none; b=tfb4ScxnXpOyzbBc30Y7eNUVESBLny2ETsKjdbyzJ7Yi+BmLbRULEMH9F0u0gvbQV47pizNdPHXyRL4vHGfW73NaqPR4206ULF88HyD0wQz/2RZfjb1euBHsrue/iKr+dzHKPHmrh1GiQxjC7CM8k1ZnPTxVRIqZE6zKU2l8VmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724077149; c=relaxed/simple; bh=dhekefwMTSVQuGOPKfOzV1PmMypiOTQ84mIKdh7dtrA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=c/XXBam11qe7un37Zilf561/QH8p/vT+5UwqiLC2NSj/lltse2AhmKtpLX5wI88CMh+O+v/WzpHxExh6sMxJaTXN3HXsu/wa2PyKyqZJ0Lpj/CqJwTZINwaeYvmYSGcQ07DGnl5rzfXucEXtS3ggHja5JWFqa6+OUmcmLMBH0sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hBTjOdyn; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hBTjOdyn" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2d1da888717so4475240a91.2 for ; Mon, 19 Aug 2024 07:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724077148; x=1724681948; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9hLxUPog6ZfK1tAJoowXx9bJNhMgN4jUhRQI7FjOx9Y=; b=hBTjOdynVn7olIuOORHzxjJbto6ZGN4x5k//tw+4Llmuae3ha4zD4NWfluh5UFZep5 pZWFg52bF8hHhleMxVCViPJl3pUMK5UVzESTda8DrtJ0mQtxh6ofJjZARHcq3eN+mkEM 5rz2bUocFTe75jwtCvzj6uoHkJdFZQq0S7AgL23eMJojt7G5TCkuzNAuZ0/qKDvgmyP7 sWhlnw2KRY25OmVqfruz3/w4YWLmmuDmMqrJfFHbl/y3I7QOef9RmTvGi8Sub8cKFiE9 qjSndVRKlFPWDRix9l1JhB6KwBQfXDwFsbf4e//JNlAav6oHHuAF8h7HoTgbuK3hhEzJ YhsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724077148; x=1724681948; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9hLxUPog6ZfK1tAJoowXx9bJNhMgN4jUhRQI7FjOx9Y=; b=gTSFkktM42VfY1qDNkDKDBtZa0Pn8Fe8FAZSWhG/x1mbFKaahaBUUxE2LmMTp81n3y dVRYw/kqxKDlq+iqFQqCeR8pi8KbzxCFMapTlTYRVrHs/UkGRLVUttfuOQqdCxsClhh2 ySOPclKXZq2Y5+RsXumix377NTYP4CnFQOYNVZ3gDZytwU625vwfRF6IIdEm15GyAMZd 9IZ/QTrJjB8jOS26SNAWymMXMQZiZctE5jRnx302jBhrjIkafHLqanjw5QJdsMZMwVjC Aje9+UMwbj2eybnT0IqtaNJezr4dGlfsHFnpYDsw61mD79fMcQv39s+4Oc52BCWeaZie Kkjw== X-Forwarded-Encrypted: i=1; AJvYcCVWrI+kiFzYKIZWufYAGTbLl47OlU7z3aqmwO/bdC8c4uIHcJ/aqUx4zapxVqW9+CtDEE7p5UGBZq9+uTma77QqMm/aPjF2LvAt2gs4 X-Gm-Message-State: AOJu0Ywkkjmc/5oyg7TYPDx8dR1P7wKhI20LbsajQVEDRH2352zVtL+m kfYjm2Z0EqNXBMXh1jnFLUhsgLMNvi0zabSS9XNz0HAQc34Fz+D13u+STei5NxGHxv/ko1M2W3j MBg== X-Google-Smtp-Source: AGHT+IEiVhcjMIh5HUWd1g2HbFSvaK6Ja8HiHcoC9dIXWYuIbXgLvSwXqZaaLQxebIQg4YAxeY37LXgLQ40= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:d817:b0:2d3:cfe1:3205 with SMTP id 98e67ed59e1d1-2d3e041dd44mr104680a91.7.1724077147516; Mon, 19 Aug 2024 07:19:07 -0700 (PDT) Date: Mon, 19 Aug 2024 07:19:07 -0700 In-Reply-To: <20240819121926.GG2032816@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-7-peterx@redhat.com> <20240814130525.GH2032816@nvidia.com> <81080764-7c94-463f-80d3-e3b2968ddf5f@redhat.com> <20240819121926.GG2032816@nvidia.com> Message-ID: Subject: Re: [PATCH 06/19] mm/pagewalk: Check pfnmap early for folio_walk_start() From: Sean Christopherson To: Jason Gunthorpe Cc: David Hildenbrand , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao Content-Type: text/plain; charset="us-ascii" On Mon, Aug 19, 2024, Jason Gunthorpe wrote: > On Fri, Aug 16, 2024 at 07:56:30PM +0200, David Hildenbrand wrote: > > > I think KVM does something nasty: if it something with a "struct page", and > > it's not PageReserved, it would take a reference (if I get > > kvm_pfn_to_refcounted_page()) independent if it's a "normal" or "not normal" > > page -- it essentially ignores the vm_normal_page() information in the page > > tables ... > > Oh that's nasty. Nothing should be upgrading the output of the follow > functions to refcounted. That's what GUP is for. > > And PFNMAP pages, even if they have struct pages for some reason, > should *NEVER* be refcounted because they are in a PFNMAP VMA. That is > completely against the whole point :\ If they could be safely > refcounted then it would be a MIXEDMAP. Yeah yeah, I'm working on it. https://lore.kernel.org/all/20240726235234.228822-1-seanjc@google.com