Re: [PATCH 0/3] soc: qcom: pmic_glink: v6.11-rc bug fixes

Bjorn Andersson
2024-08-19T14:56:39Z

On Mon, Aug 19, 2024 at 04:07:41PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 18, 2024 at 04:17:36PM -0700, Bjorn Andersson wrote:
> > Amit and Johan both reported a NULL pointer dereference in the
> > pmic_glink client code during initialization, and Stephen Boyd pointed
> > out the problem (race condition).
> >
> > While investigating, and writing the fix, I noticed that
> > ucsi_unregister() is called in atomic context but tries to sleep, and I
> > also noticed that the condition for when to inform the pmic_glink client
> > drivers when the remote has gone down is just wrong.
> >
> > So, let's fix all three.
> >
> > As mentioned in the commit message for the UCSI fix, I have a series in
> > the works that makes the GLINK callback happen in a sleepable context,
> > which would remove the need for the clients list to be protected by a
> > spinlock, and removing the work scheduling. This is however not -rc
> > material...
> >
> > In addition to the NULL pointer dereference, there is the -ECANCELED
> > issue reported here:
> > https://lore.kernel.org/all/Zqet8iInnDhnxkT9@hovoldconsulting.com/
> > I have not yet been able to either reproduce this or convince myself
> > that this is the same issue.
> >
> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> What tree are these to go through? I can take them through mine, but if
> someone else wants to, feel free to route them some other way.
>

It's primarily soc/qcom content, so I can pick them through the qcom soc
tree.

Regards,
Bjorn

> thanks,
>
> greg k-h
>