From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11563610B for ; Tue, 20 Aug 2024 00:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724112985; cv=none; b=MgHxQHjwxML1vyEcKVh2rFvMbKZbGTqEDrhEkxszy1aOAiShqodtPeJq51kX9wNYYUP6Nu4omWbxUjX0eggrQ82gDz1XwNuVMOk9uNesbYLEKuOzpqqCyCfs/beu0wsLrzYXtkoO7f2QIKFSA8MjvkzGn7zcGXZ54/QYRwDOZW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724112985; c=relaxed/simple; bh=gWVNtklo/DT5OMxK4e8dh2MliUZqgR2m2cnOOfLqdCU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YXwXkf5Q44et0xSA1WSxIgUP1N9eMfR1NiGK6HAJTzCeEenyrZ3ZAWjgnTVXspmk9hsRlnXwGRvOokgpC14+pDRxAVbAjE/qDchpARCg3Qn5sGNwCsVHkt6FF85eiPmQ0rFVtyc3PIHS/xWEqwl6Q4pYUG4atKWjpjT/3Wx82r0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=NkLVtR5x; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NkLVtR5x" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2021537a8e6so28134695ad.2 for ; Mon, 19 Aug 2024 17:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724112983; x=1724717783; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K9N3cTfP/dg7onHPw5BVcBp+wX7BOvsjJXAFs30MUm8=; b=NkLVtR5xkb9x50vJVqcRV+kOepem3C82Pvk4Fl5WlpWYS9HO1o6oICBiFHi+lTYgKn ul+4XAAKvxybrhtkUzqGVbUCvUCnmSJ9jTFOUHilhlL4S6RqMalRzrOzT08Aeax0cGwj WR1SB/4D0Y6DyQHd+JiT8rA/rEy/64dGg3R2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724112983; x=1724717783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K9N3cTfP/dg7onHPw5BVcBp+wX7BOvsjJXAFs30MUm8=; b=igrxlWw2C1S7YCPfcLTvvSngdLfaNUMs5NIkszxz/XxVz/MeuwXfhXqiLQ+5PqW3wH B6VkwSpJeTBT19N+VPJK1W4r8TOWs5pUdicx1hATQvS6fzg3XmWEeiGAauA7lqe/bJUI Tk0hUP9kentbGijFoUOhV4tPjJgplxPrQ9IL+WT9FzumnKHe9FQjI66R1qawK8DGU94G 1fCBqggNdt3aXr8LEMo9OHNG3Sb5ZD4I9JU6/lmDdKd4Ks5DoZkDGWrr8X8XNxxSuLWZ s8cuCG30bL9QZ0zU15Ww2bf2KwkKyxRQ77DKZAAsJy3lnW9n+xjTW1PBqKu5sxVZVJpk vmUw== X-Forwarded-Encrypted: i=1; AJvYcCUxK4OZ3DKYfNz4t/57nI+z19uSG7caVsLXABccXLKjpWLm6++FmTIMqcIUiUat82Dg4hmsTzkQfEa1lN0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmQFrxiUXghlxb4PvBn9ORIY7E1NdGki3Wv5MHMoOCf8VXi6VV 0QTD7m4p5rshdkNwZW7+KEpx7SVVSidgoBoG/v46BlMc4+82MdZomVdBwAMxHF0qwoaAsnbZXfA = X-Google-Smtp-Source: AGHT+IGdXHDLYADLsciH2qFBjlWj6nZa2mOjwihgQjDQOFwiAOL8MYQVozk0LMShUHg2qILme+Y8vA== X-Received: by 2002:a17:902:f988:b0:201:ff75:fa3a with SMTP id d9443c01a7336-20203ea01c9mr106734875ad.23.1724112983346; Mon, 19 Aug 2024 17:16:23 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:917:3d68:a539:4ba4]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2025f819db7sm3116295ad.257.2024.08.19.17.16.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 17:16:23 -0700 (PDT) Date: Mon, 19 Aug 2024 17:16:21 -0700 From: Brian Norris To: Sascha Hauer Cc: Francesco Dolcini , Kalle Valo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: mwifiex: remove unnecessary checks for valid priv Message-ID: References: <20240816-mwifiex-remove-priv-checks-v1-1-6dd6553e8ed9@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816-mwifiex-remove-priv-checks-v1-1-6dd6553e8ed9@pengutronix.de> On Fri, Aug 16, 2024 at 08:56:10AM +0200, Sascha Hauer wrote: > The pointers in adapter->priv[] are allocated in mwifiex_register(). > With an allocation failed the function will return an error and > driver initialization is aborted. This makes all checks for valid > priv pointers unnecessary throughout the driver. In many places > the pointers are assumed to be valid without checks, this patch > removes the remaining checks. > > Signed-off-by: Sascha Hauer Acked-by: Brian Norris