Re: [PATCH v1] pwm: lpss: wait_for_update() before configuring pwm

[Raag Jadav <raag.jadav@intel.com>]

On Mon, Aug 19, 2024 at 11:21:51AM +0300, Andy Shevchenko wrote:
> On Mon, Aug 19, 2024 at 01:34:12PM +0530, Raag Jadav wrote:
> > Wait for SW_UPDATE bit to clear before configuring pwm channel instead of
> 
> PWM
> 
> > failing right away, which will reduce failure rates on early access.
> 
> So, what is the problem this patch solves (or is trying to solve)?

Less failures with less code, so just a minor improvement.

> Second, there are two important behavioural changes:
> - error code change (it's visible to user space);

This function is already used in this path just a few lines below.

> - an additional, quite a long by the way, timeout.
> 
> Second one does worry me a lot as it might add these 0.5s to the boot time
> or so per PWM in question.

On the contrary, having a working set of PWMs would be a relatively
rewarding experience IMHO.

Raag