From: Sean Christopherson <seanjc@google.com>
To: Li Rongqing <lirongqing@baidu.com>
Cc: David Hunter <david.hunter.linux@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"javier.carrasco.cruz@gmail.com"
<javier.carrasco.cruz@gmail.com>,
"shuah@kernel.org" <shuah@kernel.org>,
Peter Shier <pshier@google.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: 答复: [外部邮件] [PATCH 6.1.y] KVM: x86: fire timer when it is migrated and expired, and in oneshot mode
Date: Tue, 20 Aug 2024 07:07:49 -0700 [thread overview]
Message-ID: <ZsSiQkQVSz0DarYC@google.com> (raw)
In-Reply-To: <57141688d6c94c789aa416906cacf08f@baidu.com>
On Tue, Aug 20, 2024, Li,Rongqing wrote:
> >
> > From: Li RongQing <lirongqing@baidu.com>
> >
> > [ Upstream Commit 8e6ed96cdd5001c55fccc80a17f651741c1ca7d2]
> >
> > when the vCPU was migrated, if its timer is expired, KVM _should_ fire the
> > timer ASAP, zeroing the deadline here will cause the timer to immediately fire
> > on the destination
> >
>
> This patch increased the reproduce ratio of lapic timer interrupt losing,
Yep, this caused a painful amount of fallout in our environment.
> which has been fixed by the following patch; so I think patch should not
> merge it into 6.1
David, can you prep a small series with both this patch and the fix below?
Thanks!
> commit 9cfec6d097c607e36199cf0cfbb8cf5acbd8e9b2
> Author: Haitao Shan <hshan@google.com>
> Date: Tue Sep 12 16:55:45 2023 -0700
next prev parent reply other threads:[~2024-08-20 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 5:32 [PATCH 6.1.y] KVM: x86: fire timer when it is migrated and expired, and in oneshot mode David Hunter
2024-08-20 6:18 ` 答复: [外部邮件] " Li,Rongqing
2024-08-20 14:07 ` Sean Christopherson [this message]
2024-08-26 22:13 ` [PATCH 6.1.y 0/2 V2] KVM: x86: fire timer when it is migrated David Hunter
2024-08-26 22:13 ` [PATCH 6.1.y 1/2 V2] KVM: x86: fire timer when it is migrated and expired, and in oneshot mode David Hunter
2024-08-26 22:13 ` [PATCH 6.1.y 2/2 V2] KVM: x86: Fix lapic timer interrupt lost after loading a snapshot David Hunter
2024-08-27 13:10 ` Greg KH
2024-08-27 18:52 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsSiQkQVSz0DarYC@google.com \
--to=seanjc@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=david.hunter.linux@gmail.com \
--cc=hpa@zytor.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox