From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] Revert "spi: ppc4xx: handle irq_of_parse_and_map() errors"
Date: Tue, 20 Aug 2024 19:44:09 +0300 [thread overview]
Message-ID: <ZsTH2cTcWQG9ltub@smile.fi.intel.com> (raw)
In-Reply-To: <f71823fb-4b9a-430a-92cc-0b9df446ce3f@sirena.org.uk>
On Tue, Aug 20, 2024 at 12:20:30PM +0100, Mark Brown wrote:
> On Mon, Aug 19, 2024 at 10:50:29PM +0300, Andy Shevchenko wrote:
> > This reverts commit f1011ba20b83da3ee70dcb4a6d9d282a718916fa.
>
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
It has the human-readable text just below that line.
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
This is a pure and clean revert, not sure if we need to hide that fact.
P.S.
You can just revert yourself the second commit if it makes it easier to
perform, I'm fine with either.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-20 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 19:50 [PATCH v1 1/1] Revert "spi: ppc4xx: handle irq_of_parse_and_map() errors" Andy Shevchenko
2024-08-20 11:20 ` Mark Brown
2024-08-20 16:44 ` Andy Shevchenko [this message]
2024-08-20 17:11 ` Mark Brown
2024-08-23 15:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsTH2cTcWQG9ltub@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox