From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE9F11B9B41; Tue, 20 Aug 2024 17:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174280; cv=none; b=W8hEFuV3u5VPKB2rTv3b9Y2Pgu4HW0OusYmmmSo69FtOEBwoUvBK6cUBREyTErmvbCoeY1jRxmT4T+tARkJNEj3mFLmY0u8AKNRuAw4oA2GKMkUVuSeqKQ5um3r3ZMfAi3TiQHthrIW/XzXAqnW/VB35NQmqo6vN4F31rXlv0vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724174280; c=relaxed/simple; bh=OxdLYrw3Fv4z03xq74l/9FObGzEEUxYeWrEJIG/DXRY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TzHFFzaQpfJ4HTCvgGTll15xMA6rli1UY9yXRh/04DsvKw0h+OcBKbMjcwo3jGJZOUEo2oqfrQM9JqlC7fWB88n9durW0o0UhBLowFtnZ8gmlloTfNc+ZGGJK6Ov3XoLWJy83pKoUMH6QXOsUEWcV+cSZPBAG9TzDsE7dOzDq6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XDGJSjkp; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XDGJSjkp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724174279; x=1755710279; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OxdLYrw3Fv4z03xq74l/9FObGzEEUxYeWrEJIG/DXRY=; b=XDGJSjkpHrVg3kbWNEivfPy5XXlReVRJaeoWkblEdCHcmf0IMH+4ewUd tnhdK2sQL3qac/6MEXPJAX+j55cw8J2+uNZIT4Vl1LSSkyemo8OYXbgU7 7Ma+Qqvc280N0tq9NVBrayFUqSfgDWmgTDua+SY93cnrgEzW2xN4c/07T hEyyKpeAgKgt3f2kxPLV3ysugmczFw4BWr1N4uRFhurdUXwzAWmteOzPX OURbVb7TbySFp1H5aB7vcrq1G8KlkXQss1/f6GnvMU7U33XrmQ9x13nGX kqgF5EpxNvRskOoX0eJs65cyt/hpRnxAJwwT5URnlFdtY48XElVAdlm/A Q==; X-CSE-ConnectionGUID: Ac8cRQKTSOWcSHSD+OfcbA== X-CSE-MsgGUID: 3zX+d2YXT4GBw3BuxOUNkA== X-IronPort-AV: E=McAfee;i="6700,10204,11170"; a="39949998" X-IronPort-AV: E=Sophos;i="6.10,162,1719903600"; d="scan'208";a="39949998" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 10:17:58 -0700 X-CSE-ConnectionGUID: xJWUE69HSnCyTK9IAsxu8w== X-CSE-MsgGUID: WQyr+7NyRB+hSvQh/sg7og== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,162,1719903600"; d="scan'208";a="64998703" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 10:17:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sgSUM-0000000HNmN-3fcK; Tue, 20 Aug 2024 20:17:46 +0300 Date: Tue, 20 Aug 2024 20:17:46 +0300 From: Andy Shevchenko To: Stephen Boyd Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Douglas Anderson , Pin-yen Lin , Andrzej Hajda , Benson Leung , Conor Dooley , Daniel Vetter , David Airlie , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Guenter Roeck , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Lee Jones , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Prashant Malani , Robert Foss , Rob Herring , Thomas Zimmermann , Tzung-Bi Shih , Alexandre Belloni , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , Ivan Orlov , linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org, Mika Westerberg , "Rafael J . Wysocki" , Sakari Ailus , Vinod Koul Subject: Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check Message-ID: References: <20240819223834.2049862-1-swboyd@chromium.org> <20240819223834.2049862-3-swboyd@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: ... > > Yeah, I really think that the appearance of this thousandth time in the Git > > history has almost no value and just pollutes the commit message makes it not > > very well readable. The only outcome is exercising the compression algo used > > by Git. > > I'll leave the decision up to the maintainers. Sure! ... > > > + /* > > > + * Ensure this bridge is aware that the next bridge wants to > > > + * reassign lanes. > > > + */ > > > + for (i = 0; i < num_input_lanes; i++) > > > + if (i != input_lanes[i].logical && !num_output_lanes) > > > + return -ENOTSUPP; > > > > Besides missing {} this code is internal to the Linux kernel. Is it okay? > > ENOTSUPP is used by select_bus_fmt_recursive() so I simply followed that > style. Okay, just be aware of that side effect of that code, also checkpatch may complain (however it might be false positive). -- With Best Regards, Andy Shevchenko