From: Carlos Llamas <cmllamas@google.com>
To: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
Cc: Will Deacon <will@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
John Stultz <jstultz@google.com>
Subject: Re: [PATCH] Revert "scripts/faddr2line: Check only two symbols when calculating symbol size"
Date: Tue, 20 Aug 2024 18:51:51 +0000 [thread overview]
Message-ID: <ZsTlxzwRK2tCTk68@google.com> (raw)
In-Reply-To: <CAOZ5it0ih05MBMzQxKuD8LYTL-by5qppjj_YXqA6iuyikm0_6w@mail.gmail.com>
On Tue, Aug 20, 2024 at 09:38:46AM -0700, Brian Johannesmeyer wrote:
>
> Acked-by: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
>
> Good catch. Thanks for the fix.
>
> Just curious: What compiler did you use to build the kernel, where you
> hit this error with 'update_irq_load_avg'? I was unable to reproduce
> it with LLVM 14. Thanks!
>
You should be able to reproduce this issue as long as you hit a NOTYPE
symbol as the second entry. Using aarch64 and CFI_CLANG will make this
scenario more likely to happen. I believe I used the following:
$ make LLVM=1 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
$ ./scripts/config -e CFI_CLANG
...
Cheers,
Carlos Llamas
next prev parent reply other threads:[~2024-08-20 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 23:01 [PATCH] Revert "scripts/faddr2line: Check only two symbols when calculating symbol size" Carlos Llamas
2024-08-16 12:50 ` Will Deacon
2024-08-20 16:38 ` Brian Johannesmeyer
2024-08-20 18:51 ` Carlos Llamas [this message]
2024-10-17 0:12 ` Carlos Llamas
2024-10-17 22:27 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsTlxzwRK2tCTk68@google.com \
--to=cmllamas@google.com \
--cc=bjohannesmeyer@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox