From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Guruvendra Punugupati <Guruvendra.Punugupati@amd.com>,
Krishnamoorthi M <krishnamoorthi.m@amd.com>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List
Date: Wed, 21 Aug 2024 16:56:45 +0300 [thread overview]
Message-ID: <ZsXyHfLJ8SJOW0RF@smile.fi.intel.com> (raw)
In-Reply-To: <9584ddb0-6e39-4d04-9242-a68eb4b86eba@amd.com>
On Wed, Aug 21, 2024 at 07:07:45PM +0530, Shyam Sundar S K wrote:
> + Andy
Thank you!
> On 8/21/2024 19:05, Shyam Sundar S K wrote:
> > The current driver code lacks the necessary plumbing for ACPI IDs,
> > preventing the mipi-i3c-hci driver from being loaded on x86
> > platforms that advertise I3C ACPI support.
> >
> > This update adds the AMDI5017 ACPI ID to the list of supported IDs.
Please, provide a DSDT excerpt to show how it will look like in the ACPI
tables.
...
> > +static const struct acpi_device_id i3c_hci_acpi_match[] = {
> > + {"AMDI5017"},
Spaces are missing
{ "AMDI5017" },
> > + {}
> > +};
> > +MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);
...
Otherwise LGTM, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-21 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 13:35 [PATCH v4 0/6] Introduce initial AMD I3C HCI driver support Shyam Sundar S K
2024-08-21 13:35 ` [PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List Shyam Sundar S K
2024-08-21 13:37 ` Shyam Sundar S K
2024-08-21 13:56 ` Andy Shevchenko [this message]
2024-08-21 15:12 ` Shyam Sundar S K
2024-08-21 15:39 ` Andy Shevchenko
2024-08-21 15:42 ` Andy Shevchenko
2024-08-21 15:43 ` Andy Shevchenko
2024-08-21 17:22 ` Shyam Sundar S K
2024-08-21 17:18 ` Shyam Sundar S K
2024-08-21 13:35 ` [PATCH v4 2/6] i3c: mipi-i3c-hci: Read HC_CONTROL_PIO_MODE only after i3c hci v1.1 Shyam Sundar S K
2024-08-23 8:50 ` Jarkko Nikula
2024-08-21 13:35 ` [PATCH v4 3/6] i3c: mipi-i3c-hci: Add a quirk to set PIO mode Shyam Sundar S K
2024-08-23 10:10 ` Jarkko Nikula
2024-08-21 13:35 ` [PATCH v4 4/6] i3c: mipi-i3c-hci: Relocate helper macros to HCI header file Shyam Sundar S K
2024-08-21 13:35 ` [PATCH v4 5/6] i3c: mipi-i3c-hci: Add a quirk to set timing parameters Shyam Sundar S K
2024-08-23 10:11 ` Jarkko Nikula
2024-08-21 13:35 ` [PATCH v4 6/6] i3c: mipi-i3c-hci: Add a quirk to set Response buffer threshold Shyam Sundar S K
2024-08-23 10:13 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsXyHfLJ8SJOW0RF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Guruvendra.Punugupati@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=krishnamoorthi.m@amd.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox